✗ CI.checkpatch: warning for drm/i915 & drm/xe: shared PCI ID macros (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 22 09:48:02 UTC 2024


== Series Details ==

Series: drm/i915 & drm/xe: shared PCI ID macros (rev2)
URL   : https://patchwork.freedesktop.org/series/138109/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 989642a6e325a76184171e2bee35965dde28ac8b
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Tue Oct 22 12:41:51 2024 +0300

    drm/xe: switch to common PCI ID macros
    
    Switch to the shared PCI ID macros in drm/intel/pciids.h. Remove
    xe_pciids.h.
    
    Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Cc: Tvrtko Ursulin <tursulin at ursulin.net>
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 411662e8995d865915235321b95f18d08fa33261 drm-intel
63151851c38e drm/i915/pciids: add PVC PCI ID macros
-:30: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#30: FILE: include/drm/intel/i915_pciids.h:784:
+#define INTEL_PVC_IDS(MACRO__, ...) \
+	MACRO__(0x0B69, ## __VA_ARGS__), \
+	MACRO__(0x0B6E, ## __VA_ARGS__), \
+	MACRO__(0x0BD4, ## __VA_ARGS__), \
+	MACRO__(0x0BD5, ## __VA_ARGS__), \
+	MACRO__(0x0BD6, ## __VA_ARGS__), \
+	MACRO__(0x0BD7, ## __VA_ARGS__), \
+	MACRO__(0x0BD8, ## __VA_ARGS__), \
+	MACRO__(0x0BD9, ## __VA_ARGS__), \
+	MACRO__(0x0BDA, ## __VA_ARGS__), \
+	MACRO__(0x0BDB, ## __VA_ARGS__), \
+	MACRO__(0x0BE0, ## __VA_ARGS__), \
+	MACRO__(0x0BE1, ## __VA_ARGS__), \
+	MACRO__(0x0BE5, ## __VA_ARGS__)

-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#30: FILE: include/drm/intel/i915_pciids.h:784:
+#define INTEL_PVC_IDS(MACRO__, ...) \
+	MACRO__(0x0B69, ## __VA_ARGS__), \
+	MACRO__(0x0B6E, ## __VA_ARGS__), \
+	MACRO__(0x0BD4, ## __VA_ARGS__), \
+	MACRO__(0x0BD5, ## __VA_ARGS__), \
+	MACRO__(0x0BD6, ## __VA_ARGS__), \
+	MACRO__(0x0BD7, ## __VA_ARGS__), \
+	MACRO__(0x0BD8, ## __VA_ARGS__), \
+	MACRO__(0x0BD9, ## __VA_ARGS__), \
+	MACRO__(0x0BDA, ## __VA_ARGS__), \
+	MACRO__(0x0BDB, ## __VA_ARGS__), \
+	MACRO__(0x0BE0, ## __VA_ARGS__), \
+	MACRO__(0x0BE1, ## __VA_ARGS__), \
+	MACRO__(0x0BE5, ## __VA_ARGS__)

total: 1 errors, 0 warnings, 1 checks, 22 lines checked
9e6d771722e5 drm/intel/pciids: rename i915_pciids.h to just pciids.h
-:73: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#73: 
rename from include/drm/intel/i915_pciids.h

total: 0 errors, 1 warnings, 0 checks, 47 lines checked
989642a6e325 drm/xe: switch to common PCI ID macros
-:123: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#123: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 93 lines checked




More information about the Intel-xe mailing list