[PATCH v2 2/3] drm/intel/pciids: rename i915_pciids.h to just pciids.h

Andi Shyti andi.shyti at linux.intel.com
Tue Oct 22 15:03:55 UTC 2024


Hi Jani,

...

> Could be intel_pciids.h too, but it's already in include/drm/intel

If we met in the coffee corner and you asked me, I would have
said that intel_pciids.h would be better, but I won't complain if
you keep it as it is.

> subdirectory.

...

> -#ifndef _I915_PCIIDS_H
> -#define _I915_PCIIDS_H
> +#ifndef __PCIIDS_H__
> +#define __PCIIDS_H__
>  
>  #ifdef __KERNEL__
>  #define INTEL_VGA_DEVICE(_id, _info) { \
> @@ -822,4 +822,4 @@
>  	MACRO__(0xB0A1, ## __VA_ARGS__), \
>  	MACRO__(0xB0A2, ## __VA_ARGS__)
>  
> -#endif /* _I915_PCIIDS_H */
> +#endif /* __PCIIDS_H__ */

Should this be __INTEL_PCIIDS_H__ anyway?

Andi


More information about the Intel-xe mailing list