✗ CI.checkpatch: warning for drm/i915/xe3lpd: ptl display patches (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Oct 24 13:12:17 UTC 2024
== Series Details ==
Series: drm/i915/xe3lpd: ptl display patches (rev2)
URL : https://patchwork.freedesktop.org/series/140195/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 12b7e77f00e82332d0c0839a9df70dd0524f1a70
Author: Mika Kahola <mika.kahola at intel.com>
Date: Wed Oct 23 14:47:01 2024 -0700
drm/i915/xe3lpd: Power request asserting/deasserting
There is a HW issue that arises when there are race conditions
between TCSS entering/exiting TC7 or TC10 states while the
driver is asserting/deasserting TCSS power request. As a
workaround, Display driver will implement a mailbox sequence
to ensure that the TCSS is in TC0 when TCSS power request is
asserted/deasserted.
The sequence is the following
1. Read mailbox command status and wait until run/busy bit is
clear
2. Write mailbox data value '1' for power request asserting
and '0' for power request deasserting
3. Write mailbox command run/busy bit and command value with 0x1
4. Read mailbox command and wait until run/busy bit is clear
before continuing power request.
Signed-off-by: Mika Kahola <mika.kahola at intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood at intel.com>
+ /mt/dim checkpatch 121cd95da591284c97d6f9ac1c58c7a79d27b201 drm-intel
c4184897b09d drm/i915/xe3lpd: Update pmdemand programming
-:77: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#77: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:341:
+ }
+ else
total: 1 errors, 0 warnings, 0 checks, 161 lines checked
5b5869f47a1a drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3
3e6f3b9349c3 drm/i915/xe3lpd: Add check to see if edp over type c is allowed
6d8e87c92707 drm/i915/display/ptl: Fill VRR crtc_state timings before other transcoder timings
5f8e9146984d drm/i915/ptl: Define IS_PANTHERLAKE macro
-:21: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i915' may be better as '(i915)' to avoid precedence issues
#21: FILE: drivers/gpu/drm/i915/i915_drv.h:539:
+#define IS_PANTHERLAKE(i915) (0 && i915)
total: 0 errors, 0 warnings, 1 checks, 7 lines checked
9091adaba6a9 drm/i915/cx0: Extend C10 check to PTL
ac64462a589a drm/i915/cx0: Remove bus reset after every c10 transaction
2779cad1fc9b drm/i915/xe3lpd: Move async flip bit to PLANE_SURF register
4fcb8c8f0bb5 drm/i915/xe3: Underrun recovery does not exist post Xe2
187bc6ed5ea6 drm/i915/display/xe3: disable x-tiled framebuffers
7d49c735959e drm/i915/xe3lpd: Skip disabling VRR during modeset disable
12b7e77f00e8 drm/i915/xe3lpd: Power request asserting/deasserting
-:95: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#95: FILE: drivers/gpu/drm/i915/i915_reg.h:4545:
+#define TCSS_DISP_MAILBOX_IN_CMD_DATA(x) TCSS_DISP_MAILBOX_IN_CMD_RUN_BUSY | \
+ REG_FIELD_PREP(TCSS_DISP_MAILBOX_IN_CMD_CMD_MASK, (x))
-:96: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#96: FILE: drivers/gpu/drm/i915/i915_reg.h:4546:
+ REG_FIELD_PREP(TCSS_DISP_MAILBOX_IN_CMD_CMD_MASK, (x))
total: 1 errors, 1 warnings, 0 checks, 65 lines checked
More information about the Intel-xe
mailing list