✗ CI.checkpatch: warning for drm/xe: Don't short circuit TDR on jobs not started (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: Don't short circuit TDR on jobs not started (rev2)
URL   : https://patchwork.freedesktop.org/series/140410/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2cf311d530381a204195f7112759bc5da0362ed6
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Wed Oct 23 19:53:23 2024 -0700

    drm/xe: Don't short circuit TDR on jobs not started
    
    Short circuiting TDR on jobs not started is an optimization which is not
    required. On LNL we are facing an issue where jobs do not get scheduled
    by the GuC if it misses a GGTT page update. When this occurs let the TDR
    fire, toggle the scheduling which may get the job unstuck, and print a
    warning message. If the TDR fires twice on job that hasn't started,
    timeout the job.
    
    v2:
     - Add warning message (Paulo)
     - Add fixes tag (Paulo)
     - Timeout job which hasn't started after TDR firing twice
    v3:
     - Include local change
    
    Fixes: 7ddb9403dd74 ("drm/xe: Sample ctx timestamp to determine if jobs have timed out")
    Cc: stable at vger.kernel.org
    Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 1feef4b713e6db15f3fb2ec11e8ce4a77892e731 drm-intel
2cf311d53038 drm/xe: Don't short circuit TDR on jobs not started
-:45: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#45: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:950:
+		return xe_sched_invalidate_job(job, 2);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 35 lines checked