✗ CI.checkpatch: warning for drm/i915/display: platform identification with display->platform.<platform> (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Thu Oct 24 23:29:44 UTC 2024
== Series Details ==
Series: drm/i915/display: platform identification with display->platform.<platform> (rev3)
URL : https://patchwork.freedesktop.org/series/139301/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 009bf4725610af8e01347cd5c8e74078a1847cff
Author: Jani Nikula <jani.nikula at intel.com>
Date: Thu Oct 24 15:33:42 2024 +0300
drm/i915/vblank: use display->platform.<platform> instead of IS_<PLATFORM>()
Switch to using the new display->platform.<platform> members for
platform identification in display code.
v2: Split out an unrelated hunk to a separate patch (Rodrigo)
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch df4c2f3aa67cea423504125ceb12ed46ac116cfb drm-intel
bc2a6e76a267 drm/i915/display: reindent subplatform initialization
f2c6bbea4c07 drm/i915/display: use a macro to initialize subplatforms
9d26a2208d9f drm/i915/display: use a macro to define platform enumerations
-:22: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18:
+#define INTEL_DISPLAY_PLATFORMS(func) \
+ func(PLATFORM_UNINITIALIZED) \
+ /* Display ver 2 */ \
+ func(I830) \
+ func(I845G) \
+ func(I85X) \
+ func(I865G) \
+ /* Display ver 3 */ \
+ func(I915G) \
+ func(I915GM) \
+ func(I945G) \
+ func(I945GM) \
+ func(G33) \
+ func(PINEVIEW) \
+ /* Display ver 4 */ \
+ func(I965G) \
+ func(I965GM) \
+ func(G45) \
+ func(GM45) \
+ /* Display ver 5 */ \
+ func(IRONLAKE) \
+ /* Display ver 6 */ \
+ func(SANDYBRIDGE) \
+ /* Display ver 7 */ \
+ func(IVYBRIDGE) \
+ func(VALLEYVIEW) \
+ func(HASWELL) \
+ /* Display ver 8 */ \
+ func(BROADWELL) \
+ func(CHERRYVIEW) \
+ /* Display ver 9 */ \
+ func(SKYLAKE) \
+ func(BROXTON) \
+ func(KABYLAKE) \
+ func(GEMINILAKE) \
+ func(COFFEELAKE) \
+ func(COMETLAKE) \
+ /* Display ver 11 */ \
+ func(ICELAKE) \
+ func(JASPERLAKE) \
+ func(ELKHARTLAKE) \
+ /* Display ver 12 */ \
+ func(TIGERLAKE) \
+ func(ROCKETLAKE) \
+ func(DG1) \
+ func(ALDERLAKE_S) \
+ /* Display ver 13 */ \
+ func(ALDERLAKE_P) \
+ func(DG2) \
+ /* Display ver 14 (based on GMD ID) */ \
+ func(METEORLAKE) \
+ /* Display ver 20 (based on GMD ID) */ \
+ func(LUNARLAKE) \
+ /* Display ver 14.1 (based on GMD ID) */ \
+ func(BATTLEMAGE) \
+ /* Display ver 30 (based on GMD ID) */ \
+ func(PANTHERLAKE)
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18:
+#define INTEL_DISPLAY_PLATFORMS(func) \
+ func(PLATFORM_UNINITIALIZED) \
+ /* Display ver 2 */ \
+ func(I830) \
+ func(I845G) \
+ func(I85X) \
+ func(I865G) \
+ /* Display ver 3 */ \
+ func(I915G) \
+ func(I915GM) \
+ func(I945G) \
+ func(I945GM) \
+ func(G33) \
+ func(PINEVIEW) \
+ /* Display ver 4 */ \
+ func(I965G) \
+ func(I965GM) \
+ func(G45) \
+ func(GM45) \
+ /* Display ver 5 */ \
+ func(IRONLAKE) \
+ /* Display ver 6 */ \
+ func(SANDYBRIDGE) \
+ /* Display ver 7 */ \
+ func(IVYBRIDGE) \
+ func(VALLEYVIEW) \
+ func(HASWELL) \
+ /* Display ver 8 */ \
+ func(BROADWELL) \
+ func(CHERRYVIEW) \
+ /* Display ver 9 */ \
+ func(SKYLAKE) \
+ func(BROXTON) \
+ func(KABYLAKE) \
+ func(GEMINILAKE) \
+ func(COFFEELAKE) \
+ func(COMETLAKE) \
+ /* Display ver 11 */ \
+ func(ICELAKE) \
+ func(JASPERLAKE) \
+ func(ELKHARTLAKE) \
+ /* Display ver 12 */ \
+ func(TIGERLAKE) \
+ func(ROCKETLAKE) \
+ func(DG1) \
+ func(ALDERLAKE_S) \
+ /* Display ver 13 */ \
+ func(ALDERLAKE_P) \
+ func(DG2) \
+ /* Display ver 14 (based on GMD ID) */ \
+ func(METEORLAKE) \
+ /* Display ver 20 (based on GMD ID) */ \
+ func(LUNARLAKE) \
+ /* Display ver 14.1 (based on GMD ID) */ \
+ func(BATTLEMAGE) \
+ /* Display ver 30 (based on GMD ID) */ \
+ func(PANTHERLAKE)
total: 1 errors, 0 warnings, 1 checks, 128 lines checked
388a37f40a47 drm/i915/display: join the platform and subplatform enums
c8d0bd6ce47c drm/i915/display: convert display platforms to lower case
3705a433276f drm/i915/display: add display platforms structure with platform members
-:67: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#67: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:110:
+#define __MEMBER(name) unsigned long name:1;
-:68: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#68: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:111:
+#define __COUNT(x) 1 +
-:68: WARNING:MACRO_ARG_UNUSED: Argument 'x' is not used in function-like macro
#68: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:111:
+#define __COUNT(x) 1 +
total: 1 errors, 2 warnings, 0 checks, 57 lines checked
1b4395feded6 drm/i915/display: add platform member to struct intel_display
3f2a36465525 drm/i915/display: remove the display platform enum as unnecessary
b4bff2e446b1 drm/i915/display: add platform group for g4x
daceedea8bd8 drm/i915/display: add subplatform group for HSW/BDW ULT
800e8119d15d drm/i915/bios: use display->platform.<platform> instead of IS_<PLATFORM>()
0753e6a19d12 drm/i915/pps: use display->platform.<platform> instead of IS_<PLATFORM>()
63d54bfcee12 drm/i915/tv: use display->platform.<platform> instead of IS_<PLATFORM>()
fc2bba82dbc3 drm/i915/vga: use display->platform.<platform> instead of IS_<PLATFORM>()
1b6d0183f38a drm/i915/vblank: drop unnecessary i915 local variable
009bf4725610 drm/i915/vblank: use display->platform.<platform> instead of IS_<PLATFORM>()
More information about the Intel-xe
mailing list