[PATCH v4 10/11] drm/i915/xe3lpd: Skip disabling VRR during modeset disable

[Golani, Mitulkumar Ajitkumar]

Hello @Taylor, Clinton A

This patch can be dropped from here, We are handling this scenario with Ankit's VRR default timing generator patch series.

https://patchwork.freedesktop.org/series/134383/ 

-Mitul

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Golani, Mitulkumar Ajitkumar
> Sent: 25 October 2024 13:37
> To: Taylor, Clinton A <clinton.a.taylor at intel.com>; intel-
> gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
> Cc: Kurmi, Suresh Kumar <suresh.kumar.kurmi at intel.com>; Nautiyal, Ankit K
> <ankit.k.nautiyal at intel.com>
> Subject: RE: [PATCH v4 10/11] drm/i915/xe3lpd: Skip disabling VRR during
> modeset disable
> 
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > Clint Taylor
> > Sent: 25 October 2024 04:01
> > To: intel-gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
> > Subject: [PATCH v4 10/11] drm/i915/xe3lpd: Skip disabling VRR during
> > modeset disable
> >
> > From: Ravi Kumar Vodapalli <ravi.kumar.vodapalli at intel.com>
> >
> > Spec does not request to disable VRR in the modeset disabling sequence
> > for DP and HDMI for xe3_lpd.
> >
> > Bspec: 68848
> > Signed-off-by: Ravi Kumar Vodapalli <ravi.kumar.vodapalli at intel.com>
> > Signed-off-by: Matt Atwood <matthew.s.atwood at intel.com>
> > Signed-off-by: Clint Taylor <Clinton.A.Taylor at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index c904f529d0c5..7a6961432616 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -1310,9 +1310,11 @@ static void intel_pre_plane_update(struct
> > intel_atomic_state *state,
> >  		intel_atomic_get_new_crtc_state(state, crtc);
> >  	enum pipe pipe = crtc->pipe;
> >
> > -	if (intel_crtc_vrr_disabling(state, crtc)) {
> > -		intel_vrr_disable(old_crtc_state);
> > -		intel_crtc_update_active_timings(old_crtc_state, false);
> > +	if (DISPLAY_VER(dev_priv) < 30) {
> > +		if (intel_crtc_vrr_disabling(state, crtc)) {
> > +			intel_vrr_disable(old_crtc_state);
> > +			intel_crtc_update_active_timings(old_crtc_state,
> > false);
> > +		}
> 
> Hello @Clint Taylor
> 
> Seems comments from revision 2 got missed ?
> 
> https://patchwork.freedesktop.org/patch/621235/?series=140196&rev=2
> 
> 
> >  	}
> >
> >  	if (audio_disabling(old_crtc_state, new_crtc_state))
> > --
> > 2.25.1