✗ CI.checkpatch: warning for drm/xe: Rework throttle ABI
Patchwork
patchwork at emeril.freedesktop.org
Fri Oct 25 10:30:31 UTC 2024
== Series Details ==
Series: drm/xe: Rework throttle ABI
URL : https://patchwork.freedesktop.org/series/140481/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 766fcc145d25e9224f80e1dc57d206f438735414
Author: Raag Jadav <raag.jadav at intel.com>
Date: Fri Oct 25 14:52:38 2024 +0530
drm/xe: Rework throttle ABI
Current implementation adds multiple sysfs entries for getting GT
throttle status and its reasons, which forces the user to read multiple
entries for evaluating the result. Since output of each entry is based
on the same underlying hardware register and considering the access type
of this register is RO/v, the value of this register can change at any
given point, even between subsequent sysfs reads. This makes current
implementation fundamentally flawed which can produce inconsistent results.
Rework throttle ABI and introduce throttle_status attribute which will
provide throttle status through a oneshot register read, making it
relatively less error prone. The new ABI will provide throttle reasons
in a string based list based on the respective bits which are set in the
hardware. Empty output means no bits are set and hence no throttling.
$ cat /sys/devices/.../tile0/gt0/freq0/throttle_status
prochot
thermal
ratl
thermalert
tdc
pl4
pl1
pl2
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2810
Signed-off-by: Raag Jadav <raag.jadav at intel.com>
+ /mt/dim checkpatch 7cadd167321b3267a9803aba88f115fc9809d4ea drm-intel
766fcc145d25 drm/xe: Rework throttle ABI
-:72: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#72: FILE: drivers/gpu/drm/xe/xe_gt_throttle.c:35:
+};
+static_assert(ARRAY_SIZE(throttle_reasons) == ffs(POWER_LIMIT_2_MASK));
total: 0 errors, 0 warnings, 1 checks, 253 lines checked
More information about the Intel-xe
mailing list