✗ CI.checkpatch: warning for drm/xe: Fix races on fdinfo

[Patchwork]

== Series Details ==

Series: drm/xe: Fix races on fdinfo
URL   : https://patchwork.freedesktop.org/series/140544/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2bb31ce6e9c0f65ec73dc9a4de25396fe0d9de0e
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Sat Oct 26 12:08:48 2024 -0500

    drm/xe: Stop accumulating LRC timestamp on job_free
    
    The exec queue timestamp is only really useful when it's being queried
    through the fdinfo. There's no need to update it so often, on every
    job_free. Tracing a simple app like vkcube running shows an update
    rate of ~ 120Hz.
    
    The update on job_free() is used to cover a gap: if exec
    queue is created and destroyed rapidily, before a new query, the
    timestamp still needs to be accumulated and accounted on the xef.
    Initial implementation in commit 6109f24f87d7 ("drm/xe: Add helper to
    accumulate exec queue runtime") couldn't do it on the exec_queue_fini
    since the xef could be gone at that point. However since commit
    ce8c161cbad4 ("drm/xe: Add ref counting for xe_file") the xef is
    refcounted and the exec queue has a reference.
    
    Improve the fix in commit 2149ded63079 ("drm/xe: Fix use after free when
    client stats are captured") by reducing the frequency in which the
    update is needed.
    
    Fixes: 2149ded63079 ("drm/xe: Fix use after free when client stats are captured")
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 3ec61d11c7429a65dcc3ac46b9e845f13891a306 drm-intel
2262fad6af49 drm/xe: Add trace to lrc timestamp update
-:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

-:86: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#86: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:24:
+	    TP_STRUCT__entry(

-:94: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#94: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:32:
+	    TP_fast_assign(

-:112: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#112: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
                              ^

-:112: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#112: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
                                 ^

-:112: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#112: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
                                         ^

-:112: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#112: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
                                             ^

-:112: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#112: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
                                                 ^

total: 0 errors, 1 warnings, 7 checks, 82 lines checked
4654486a329d drm/xe: Accumulate exec queue timestamp on destroy
2bb31ce6e9c0 drm/xe: Stop accumulating LRC timestamp on job_free