✗ CI.checkpatch: warning for drm/i915/display: platform identification with display->platform.<platform> (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Mon Oct 28 21:44:12 UTC 2024
== Series Details ==
Series: drm/i915/display: platform identification with display->platform.<platform> (rev4)
URL : https://patchwork.freedesktop.org/series/139301/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 81150cceefa09126cb767e6f2b0cb0428ff87c49
Author: Jani Nikula <jani.nikula at intel.com>
Date: Mon Oct 28 21:48:49 2024 +0200
drm/i915/vblank: use display->platform.<platform> instead of IS_<PLATFORM>()
Switch to using the new display->platform.<platform> members for
platform identification in display code.
v2: Split out an unrelated hunk to a separate patch (Rodrigo)
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 810b65a3bab4c67517ef050df06dcf998d66b664 drm-intel
62388da5acf7 drm/i915/display: reindent subplatform initialization
6f414599f6eb drm/i915/display: use a macro to initialize subplatforms
150ad3679427 drm/i915/display: use a macro to define platform enumerations
-:22: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18:
+#define INTEL_DISPLAY_PLATFORMS(func) \
+ func(PLATFORM_UNINITIALIZED) \
+ /* Display ver 2 */ \
+ func(I830) \
+ func(I845G) \
+ func(I85X) \
+ func(I865G) \
+ /* Display ver 3 */ \
+ func(I915G) \
+ func(I915GM) \
+ func(I945G) \
+ func(I945GM) \
+ func(G33) \
+ func(PINEVIEW) \
+ /* Display ver 4 */ \
+ func(I965G) \
+ func(I965GM) \
+ func(G45) \
+ func(GM45) \
+ /* Display ver 5 */ \
+ func(IRONLAKE) \
+ /* Display ver 6 */ \
+ func(SANDYBRIDGE) \
+ /* Display ver 7 */ \
+ func(IVYBRIDGE) \
+ func(VALLEYVIEW) \
+ func(HASWELL) \
+ /* Display ver 8 */ \
+ func(BROADWELL) \
+ func(CHERRYVIEW) \
+ /* Display ver 9 */ \
+ func(SKYLAKE) \
+ func(BROXTON) \
+ func(KABYLAKE) \
+ func(GEMINILAKE) \
+ func(COFFEELAKE) \
+ func(COMETLAKE) \
+ /* Display ver 11 */ \
+ func(ICELAKE) \
+ func(JASPERLAKE) \
+ func(ELKHARTLAKE) \
+ /* Display ver 12 */ \
+ func(TIGERLAKE) \
+ func(ROCKETLAKE) \
+ func(DG1) \
+ func(ALDERLAKE_S) \
+ /* Display ver 13 */ \
+ func(ALDERLAKE_P) \
+ func(DG2) \
+ /* Display ver 14 (based on GMD ID) */ \
+ func(METEORLAKE) \
+ /* Display ver 20 (based on GMD ID) */ \
+ func(LUNARLAKE) \
+ /* Display ver 14.1 (based on GMD ID) */ \
+ func(BATTLEMAGE) \
+ /* Display ver 30 (based on GMD ID) */ \
+ func(PANTHERLAKE)
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18:
+#define INTEL_DISPLAY_PLATFORMS(func) \
+ func(PLATFORM_UNINITIALIZED) \
+ /* Display ver 2 */ \
+ func(I830) \
+ func(I845G) \
+ func(I85X) \
+ func(I865G) \
+ /* Display ver 3 */ \
+ func(I915G) \
+ func(I915GM) \
+ func(I945G) \
+ func(I945GM) \
+ func(G33) \
+ func(PINEVIEW) \
+ /* Display ver 4 */ \
+ func(I965G) \
+ func(I965GM) \
+ func(G45) \
+ func(GM45) \
+ /* Display ver 5 */ \
+ func(IRONLAKE) \
+ /* Display ver 6 */ \
+ func(SANDYBRIDGE) \
+ /* Display ver 7 */ \
+ func(IVYBRIDGE) \
+ func(VALLEYVIEW) \
+ func(HASWELL) \
+ /* Display ver 8 */ \
+ func(BROADWELL) \
+ func(CHERRYVIEW) \
+ /* Display ver 9 */ \
+ func(SKYLAKE) \
+ func(BROXTON) \
+ func(KABYLAKE) \
+ func(GEMINILAKE) \
+ func(COFFEELAKE) \
+ func(COMETLAKE) \
+ /* Display ver 11 */ \
+ func(ICELAKE) \
+ func(JASPERLAKE) \
+ func(ELKHARTLAKE) \
+ /* Display ver 12 */ \
+ func(TIGERLAKE) \
+ func(ROCKETLAKE) \
+ func(DG1) \
+ func(ALDERLAKE_S) \
+ /* Display ver 13 */ \
+ func(ALDERLAKE_P) \
+ func(DG2) \
+ /* Display ver 14 (based on GMD ID) */ \
+ func(METEORLAKE) \
+ /* Display ver 20 (based on GMD ID) */ \
+ func(LUNARLAKE) \
+ /* Display ver 14.1 (based on GMD ID) */ \
+ func(BATTLEMAGE) \
+ /* Display ver 30 (based on GMD ID) */ \
+ func(PANTHERLAKE)
total: 1 errors, 0 warnings, 1 checks, 128 lines checked
9cd87ee3cbc1 drm/i915/display: join the platform and subplatform enums
43301309fffd drm/i915/display: convert display platforms to lower case
e6d35039a7d9 drm/i915/display: add display platforms structure with platform members
-:67: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#67: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:110:
+#define __MEMBER(name) unsigned long name:1;
-:68: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#68: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:111:
+#define __COUNT(x) 1 +
-:68: WARNING:MACRO_ARG_UNUSED: Argument 'x' is not used in function-like macro
#68: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:111:
+#define __COUNT(x) 1 +
total: 1 errors, 2 warnings, 0 checks, 57 lines checked
0e06fe31e143 drm/i915/display: add platform member to struct intel_display
e797d30bcad2 drm/i915/display: remove the display platform enum as unnecessary
38206d15b61a drm/i915/display: add platform group for g4x
236b6abc17b1 drm/i915/display: add subplatform group for HSW/BDW ULT
35fa67722295 drm/i915/bios: use display->platform.<platform> instead of IS_<PLATFORM>()
211963831f76 drm/i915/pps: use display->platform.<platform> instead of IS_<PLATFORM>()
c2a869970a17 drm/i915/tv: use display->platform.<platform> instead of IS_<PLATFORM>()
23279c73f198 drm/i915/vga: use display->platform.<platform> instead of IS_<PLATFORM>()
d5a09f1c2cc9 drm/i915/vblank: drop unnecessary i915 local variable
81150cceefa0 drm/i915/vblank: use display->platform.<platform> instead of IS_<PLATFORM>()
More information about the Intel-xe
mailing list