✗ CI.checkpatch: warning for drm/i915/display: use x100 version for full version and release (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Tue Oct 29 18:13:15 UTC 2024
== Series Details ==
Series: drm/i915/display: use x100 version for full version and release (rev3)
URL : https://patchwork.freedesktop.org/series/140455/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e996584a5a32475ca5689849b5063510309ab431
Author: Jani Nikula <jani.nikula at intel.com>
Date: Tue Oct 29 17:55:36 2024 +0200
drm/i915/display: use x100 version for full version and release
Use x100, or ver * 100 + rel, versions for full IP version checks,
similar to what xe driver does:
- Replace IP_VER(14, 1) inline with 1401, etc.
- Convert DISPLAY_VER_FULL() to DISPLAY_VERx100()
- Convert IS_DISPLAY_VER_FULL() to IS_DISPLAY_VERx100()
- Convert IS_DISPLAY_VER_STEP() to IS_DISPLAY_VERx100_STEP()
This makes ver.rel versions easier to use, follows the xe driver
pattern, and drops the dependency on the IP_VER() macro.
v2: Rebase, drop IP_VER() from xe compat headers
v3: Rebase
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Acked-by: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 95fd9af8bb5389f9b5a639d567ef5c3e43e25682 drm-intel
e996584a5a32 drm/i915/display: use x100 version for full version and release
-:129: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects?
#129: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:171:
+#define IS_DISPLAY_VERx100(__i915, from, until) ( \
+ BUILD_BUG_ON_ZERO((from) < 200) + \
+ (DISPLAY_VERx100(__i915) >= (from) && \
+ DISPLAY_VERx100(__i915) <= (until)))
-:129: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'from' - possible side-effects?
#129: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:171:
+#define IS_DISPLAY_VERx100(__i915, from, until) ( \
+ BUILD_BUG_ON_ZERO((from) < 200) + \
+ (DISPLAY_VERx100(__i915) >= (from) && \
+ DISPLAY_VERx100(__i915) <= (until)))
-:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects?
#150: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:191:
+#define IS_DISPLAY_VERx100_STEP(__i915, ipver, from, until) \
+ (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
IS_DISPLAY_STEP((__i915), (from), (until)))
-:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ipver' - possible side-effects?
#150: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:191:
+#define IS_DISPLAY_VERx100_STEP(__i915, ipver, from, until) \
+ (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
IS_DISPLAY_STEP((__i915), (from), (until)))
-:160: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#160: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:199:
+#define DISPLAY_VERx100(i915) (DISPLAY_RUNTIME_INFO(i915)->ip.ver * 100 + \
+ DISPLAY_RUNTIME_INFO(i915)->ip.rel)
total: 0 errors, 0 warnings, 5 checks, 223 lines checked
More information about the Intel-xe
mailing list