[PATCH v2 3/4] drm/xe: Reword exec_queue.lock doc

Cavitt, Jonathan jonathan.cavitt at intel.com
Tue Oct 29 21:50:08 UTC 2024


-----Original Message-----
From: De Marchi, Lucas <lucas.demarchi at intel.com> 
Sent: Tuesday, October 29, 2024 2:44 PM
To: intel-xe at lists.freedesktop.org
Cc: Cavitt, Jonathan <jonathan.cavitt at intel.com>; Nerlige Ramappa, Umesh <umesh.nerlige.ramappa at intel.com>; Brost, Matthew <matthew.brost at intel.com>; De Marchi, Lucas <lucas.demarchi at intel.com>
Subject: [PATCH v2 3/4] drm/xe: Reword exec_queue.lock doc
> 
> Reword documentation to possibly what it meant to be.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Yeah, that looks a lot better.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 85bede4dd6461..ef7412d653d2e 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -597,7 +597,7 @@ struct xe_file {
>  		/** @vm.xe: xarray to store VMs */
>  		struct xarray xa;
>  		/**
> -		 * @vm.lock: Protects VM lookup + reference and removal a from
> +		 * @vm.lock: Protects VM lookup + reference and removal from
>  		 * file xarray. Not an intended to be an outer lock which does
>  		 * thing while being held.
>  		 */
> @@ -610,8 +610,8 @@ struct xe_file {
>  		struct xarray xa;
>  		/**
>  		 * @exec_queue.lock: Protects exec queue lookup + reference and
> -		 * removal a frommfile xarray. Not an intended to be an outer
> -		 * lock which does thing while being held.
> +		 * removal from file xarray. Not intended to be an outer lock
> +		 * which does things while being held.
>  		 */
>  		struct mutex lock;
>  	} exec_queue;
> -- 
> 2.47.0
> 
> 


More information about the Intel-xe mailing list