✗ CI.checkpatch: warning for drm/xe: Fix races on fdinfo (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Tue Oct 29 22:30:41 UTC 2024
== Series Details ==
Series: drm/xe: Fix races on fdinfo (rev3)
URL : https://patchwork.freedesktop.org/series/140544/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 88eaa89a9cee0e1b517026667e35ac5d9b1c268c
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date: Tue Oct 29 14:43:51 2024 -0700
drm/xe: Wait on killed exec queues
When an exec queue is killed it triggers an async process of asking the
GuC to schedule the context out. The timestamp in the context image is
only updated when this process completes. In case a userspace process
kills an exec and tries to read the timestamp, it may not get an updated
runtime.
Add synchronization between the process reading the fdinfo and the exec
queue being killed. After reading all the timestamps, wait on exec
queues in the process of being killed. When that wait is over,
xe_exec_queue_fini() was already called and updated the timestamps.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2667
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
+ /mt/dim checkpatch fb2691707e2d5a8c704ae5e48bc5a314a308b0e0 drm-intel
d5ea1e0d7da0 drm/xe: Add trace to lrc timestamp update
-:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
-:87: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#87: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:24:
+ TP_STRUCT__entry(
-:95: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#95: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:32:
+ TP_fast_assign(
-:113: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#113: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
^
-:113: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#113: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
^
-:113: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#113: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
^
-:113: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#113: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
^
-:113: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#113: FILE: drivers/gpu/drm/xe/xe_trace_lrc.h:50:
+#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe
^
total: 0 errors, 1 warnings, 7 checks, 82 lines checked
ff53d2f28e68 drm/xe: Stop accumulating LRC timestamp on job_free
07544f1cb238 drm/xe: Reword exec_queue.lock doc
88eaa89a9cee drm/xe: Wait on killed exec queues
More information about the Intel-xe
mailing list