[PATCH 1/3] drm/xe: Add XE_BO_FLAG_PINNED_WONTNEED

[Matthew Brost]

On Wed, Oct 30, 2024 at 11:23:40PM -0500, Lucas De Marchi wrote:
> On Tue, Oct 29, 2024 at 02:55:11PM +0000, Matthew Brost wrote:
> > On Tue, Oct 29, 2024 at 09:30:50AM -0400, Rodrigo Vivi wrote:
> > > On Mon, Oct 28, 2024 at 05:32:22PM -0700, Matthew Brost wrote:
> > > > Not all BOs need to restored on resume / d3cold exit, add
> > > > XE_BO_FLAG_PINNED_WONTNEED which skips restoring of BOs rather just
> > > > allocates VRAM for the BO. This should slighly speedup resume / d3cold
> > > > exit flows.
> > > >
> > > > Marking GuC ADS, GuC CT, GuC log, GuC PC, and SA as WONTNEED.
> > > 
> > > What about s/WONTNEED/NORESTORE ?
> 
> since you are renaming, can you quantify "This should slighly speedup
> resume"?
> 
> I think you can just trace xe_bo_evict_pinned and xe_bo_restore_pinned
> and see how much it improves...
> 

Sure. Probably will drop patch 1, 3 for now though as 2 fixes an issue
in our downstream driver. I've distracted myself with other work but
when I revive 1, 3 agree it would be to quantify the actual improvement
here.

Matt

> Lucas De Marchi