✗ CI.checkpatch: warning for drm/i915 & drm/xe: shared PCI ID macros
Patchwork
patchwork at emeril.freedesktop.org
Mon Sep 2 18:06:08 UTC 2024
== Series Details ==
Series: drm/i915 & drm/xe: shared PCI ID macros
URL : https://patchwork.freedesktop.org/series/138109/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 91e90f299d16f6a1be8fef42f3d9598bea0bf2d1
Author: Jani Nikula <jani.nikula at intel.com>
Date: Mon Sep 2 20:14:07 2024 +0300
drm/xe: switch to common PCI ID macros
Switch to the shared PCI ID macros in drm/intel/pciids.h. Remove
xe_pciids.h.
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch f68a30b6b56c006ab1d6bca3b4ccf7aed1b2743e drm-intel
2a79329d0cf8 drm/i915/pciids: use designated initializers in INTEL_VGA_DEVICE()
81c626e5f4ad drm/i915/pciids: separate ARL and MTL PCI IDs
51180c0999c1 drm/xe/pciids: add some missing ADL-N PCI IDs
774fd36a11e5 drm/xe/pciids: separate RPL-U and RPL-P PCI IDs
ad9787b4ac25 drm/xe/pciids: separate ARL and MTL PCI IDs
-:34: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#34: FILE: include/drm/intel/xe_pciids.h:180:
+#define XE_ARL_IDS(MACRO__, ...) \
+ MACRO__(0x7D41, ## __VA_ARGS__), \
+ MACRO__(0x7D51, ## __VA_ARGS__), \
+ MACRO__(0x7D67, ## __VA_ARGS__), \
+ MACRO__(0x7DD1, ## __VA_ARGS__)
-:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#34: FILE: include/drm/intel/xe_pciids.h:180:
+#define XE_ARL_IDS(MACRO__, ...) \
+ MACRO__(0x7D41, ## __VA_ARGS__), \
+ MACRO__(0x7D51, ## __VA_ARGS__), \
+ MACRO__(0x7D67, ## __VA_ARGS__), \
+ MACRO__(0x7DD1, ## __VA_ARGS__)
total: 1 errors, 0 warnings, 1 checks, 31 lines checked
bafa3d232a51 drm/i915/pciids: add PVC PCI ID macros
-:22: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#22: FILE: include/drm/intel/i915_pciids.h:783:
+#define INTEL_PVC_IDS(MACRO__, ...) \
+ MACRO__(0x0B69, ## __VA_ARGS__), \
+ MACRO__(0x0B6E, ## __VA_ARGS__), \
+ MACRO__(0x0BD4, ## __VA_ARGS__), \
+ MACRO__(0x0BD5, ## __VA_ARGS__), \
+ MACRO__(0x0BD6, ## __VA_ARGS__), \
+ MACRO__(0x0BD7, ## __VA_ARGS__), \
+ MACRO__(0x0BD8, ## __VA_ARGS__), \
+ MACRO__(0x0BD9, ## __VA_ARGS__), \
+ MACRO__(0x0BDA, ## __VA_ARGS__), \
+ MACRO__(0x0BDB, ## __VA_ARGS__), \
+ MACRO__(0x0BE0, ## __VA_ARGS__), \
+ MACRO__(0x0BE1, ## __VA_ARGS__), \
+ MACRO__(0x0BE5, ## __VA_ARGS__)
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#22: FILE: include/drm/intel/i915_pciids.h:783:
+#define INTEL_PVC_IDS(MACRO__, ...) \
+ MACRO__(0x0B69, ## __VA_ARGS__), \
+ MACRO__(0x0B6E, ## __VA_ARGS__), \
+ MACRO__(0x0BD4, ## __VA_ARGS__), \
+ MACRO__(0x0BD5, ## __VA_ARGS__), \
+ MACRO__(0x0BD6, ## __VA_ARGS__), \
+ MACRO__(0x0BD7, ## __VA_ARGS__), \
+ MACRO__(0x0BD8, ## __VA_ARGS__), \
+ MACRO__(0x0BD9, ## __VA_ARGS__), \
+ MACRO__(0x0BDA, ## __VA_ARGS__), \
+ MACRO__(0x0BDB, ## __VA_ARGS__), \
+ MACRO__(0x0BE0, ## __VA_ARGS__), \
+ MACRO__(0x0BE1, ## __VA_ARGS__), \
+ MACRO__(0x0BE5, ## __VA_ARGS__)
total: 1 errors, 0 warnings, 1 checks, 22 lines checked
b6efd4f6c383 drm/intel/pciids: rename i915_pciids.h to just pciids.h
-:65: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#65:
rename from include/drm/intel/i915_pciids.h
total: 0 errors, 1 warnings, 0 checks, 47 lines checked
91e90f299d16 drm/xe: switch to common PCI ID macros
-:113: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#113:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
More information about the Intel-xe
mailing list