[PATCH] drm/xe: Remove redundant [drm] tag from xe_assert() message

Lucas De Marchi lucas.demarchi at intel.com
Tue Sep 3 02:36:00 UTC 2024


On Mon, Sep 02, 2024 at 09:07:26PM GMT, Michal Wajdeczko wrote:
>Since commit 178c0a33c421 ("drm/print: Add generic drm dev printk
>function") the output from drm_WARN() includes previously missing
>the [drm] tag, so now xe_assert() is printing it twice:
>
>  [ ] xe 0000:00:02.0: [drm] [drm] Assertion `false` failed!
>
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_assert.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
>index 8b0cc1bc9327..e22bbf57fca7 100644
>--- a/drivers/gpu/drm/xe/xe_assert.h
>+++ b/drivers/gpu/drm/xe/xe_assert.h
>@@ -81,7 +81,7 @@
>
> #if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
> #define __xe_assert_msg(xe, condition, msg, arg...) ({						\
>-	(void)drm_WARN(&(xe)->drm, !(condition), "[" DRM_NAME "] Assertion `%s` failed!\n" msg,	\
>+	(void)drm_WARN(&(xe)->drm, !(condition), "Assertion `%s` failed!\n" msg,		\
> 		       __stringify(condition), ## arg);						\
> })
> #else
>-- 
>2.43.0
>


More information about the Intel-xe mailing list