[PATCH 1/2] drm/xe: Cleanup has_flat_ccs handling

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas De Marchi
Sent: Wednesday, September 4, 2024 9:23 AM
To: intel-xe at lists.freedesktop.org
Cc: De Marchi, Lucas <lucas.demarchi at intel.com>; Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>; Roper, Matthew D <matthew.d.roper at intel.com>
Subject: [PATCH 1/2] drm/xe: Cleanup has_flat_ccs handling
> 
> The flag is set in XE_HP_FEATURES, but then overridden in all but one
> xe_graphics_desc. Make it set only where needed.
> 
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_pci.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 7eb00a87b786..8642c079bc65 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -103,7 +103,6 @@ static const struct xe_graphics_desc graphics_xelpp = {
>  
>  #define XE_HP_FEATURES \
>  	.has_range_tlb_invalidation = true, \
> -	.has_flat_ccs = true, \
>  	.dma_mask_size = 46, \
>  	.va_bits = 48, \
>  	.vm_max_level = 3
> @@ -120,6 +119,8 @@ static const struct xe_graphics_desc graphics_xehpg = {
>  
>  	XE_HP_FEATURES,
>  	.vram_flags = XE_VRAM_FLAGS_NEED64K,
> +
> +	.has_flat_ccs = 1,
>  };
>  
>  static const struct xe_graphics_desc graphics_xehpc = {
> @@ -145,7 +146,6 @@ static const struct xe_graphics_desc graphics_xehpc = {
>  
>  	.has_asid = 1,
>  	.has_atomic_enable_pte_bit = 1,
> -	.has_flat_ccs = 0,
>  	.has_usm = 1,
>  };
>  
> @@ -156,7 +156,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
>  		BIT(XE_HW_ENGINE_CCS0),
>  
>  	XE_HP_FEATURES,
> -	.has_flat_ccs = 0,
>  };
>  
>  #define XE2_GFX_FEATURES \
> -- 
> 2.43.0
> 
>