✗ CI.checkpatch: warning for drm/xe: split PVC PCI ID commit to two

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 6 12:13:46 UTC 2024


== Series Details ==

Series: drm/xe: split PVC PCI ID commit to two
URL   : https://patchwork.freedesktop.org/series/138327/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1deadd711d91a513172930a7494f1864f098c251
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Fri Sep 6 15:06:04 2024 +0300

    drm/xe: Add PVC's PCI device IDs
    
    This patch introduces Ponte Vecchio support in Xe driver.
    
    Please note that besides this patch, likely the force_probe
    still needs to be used in order to actually enable the
    support for PVC.
    
    This patch was separated from the rest so we can ensure
    compliance with DRM uAPI rules on compute platforms.
    
    Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1154
    Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch d4b15a4609f1b768b0301fd238022ab8d07d15bc drm-intel
9a84da4cdfb7 Revert "drm/xe: Add PVC's PCI device IDs"
66f993684da9 drm/xe/pciids: Add PVC's PCI device ID macros
-:28: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#28: FILE: include/drm/intel/xe_pciids.h:191:
+#define XE_PVC_IDS(MACRO__, ...)		\
+	MACRO__(0x0B69, ## __VA_ARGS__),	\
+	MACRO__(0x0B6E, ## __VA_ARGS__),	\
+	MACRO__(0x0BD4, ## __VA_ARGS__),	\
+	MACRO__(0x0BD5, ## __VA_ARGS__),	\
+	MACRO__(0x0BD6, ## __VA_ARGS__),	\
+	MACRO__(0x0BD7, ## __VA_ARGS__),	\
+	MACRO__(0x0BD8, ## __VA_ARGS__),	\
+	MACRO__(0x0BD9, ## __VA_ARGS__),	\
+	MACRO__(0x0BDA, ## __VA_ARGS__),	\
+	MACRO__(0x0BDB, ## __VA_ARGS__),	\
+	MACRO__(0x0BE0, ## __VA_ARGS__),	\
+	MACRO__(0x0BE1, ## __VA_ARGS__),	\
+	MACRO__(0x0BE5, ## __VA_ARGS__)

-:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#28: FILE: include/drm/intel/xe_pciids.h:191:
+#define XE_PVC_IDS(MACRO__, ...)		\
+	MACRO__(0x0B69, ## __VA_ARGS__),	\
+	MACRO__(0x0B6E, ## __VA_ARGS__),	\
+	MACRO__(0x0BD4, ## __VA_ARGS__),	\
+	MACRO__(0x0BD5, ## __VA_ARGS__),	\
+	MACRO__(0x0BD6, ## __VA_ARGS__),	\
+	MACRO__(0x0BD7, ## __VA_ARGS__),	\
+	MACRO__(0x0BD8, ## __VA_ARGS__),	\
+	MACRO__(0x0BD9, ## __VA_ARGS__),	\
+	MACRO__(0x0BDA, ## __VA_ARGS__),	\
+	MACRO__(0x0BDB, ## __VA_ARGS__),	\
+	MACRO__(0x0BE0, ## __VA_ARGS__),	\
+	MACRO__(0x0BE1, ## __VA_ARGS__),	\
+	MACRO__(0x0BE5, ## __VA_ARGS__)

total: 1 errors, 0 warnings, 1 checks, 22 lines checked
1deadd711d91 drm/xe: Add PVC's PCI device IDs




More information about the Intel-xe mailing list