✗ CI.checkpatch: warning for drm/i915: Some intel_display conversions

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 6 14:39:33 UTC 2024


== Series Details ==

Series: drm/i915: Some intel_display conversions
URL   : https://patchwork.freedesktop.org/series/138332/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a799ab76dab9756d15c845ede2fc534a88e3b15a
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date:   Fri Sep 6 17:33:06 2024 +0300

    drm/i915/dmc: Convert DMC code to intel_display
    
    struct intel_display will replace struct drm_i915_private as
    the main thing for display code. Convert the DMC code to
    use it (as much as possible at this stage).
    
    Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch 6094a8d70f8599700297da58bcf80d5b1915adff drm-intel
21ad6884653f drm/i915/cdclk: Add missing braces
6c326db98005 drm/i915/cdclk: Convert CDCLK code to intel_display
-:1465: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26)
#1465: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2103:
+	if (DISPLAY_VER(display) >= 14 || IS_DG2(dev_priv))
 		/* NOOP */;

-:1506: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#1506: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2140:
+	if (DISPLAY_VER(display) >= 14)
[...]
 		 */;

-:2893: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2893: FILE: drivers/gpu/drm/i915/display/intel_display_driver.c:95:
+	cdclk_state->logical = cdclk_state->actual = display->cdclk.hw;

total: 0 errors, 2 warnings, 1 checks, 2934 lines checked
85d00811b21f drm/i915/power: Convert low level DC state code to intel_display
260fd3797a3d drm/i915/vga: Convert VGA code to intel_display
0d7e59b0508c drm/i915/power: Convert "i830 power well" code to intel_display
a799ab76dab9 drm/i915/dmc: Convert DMC code to intel_display
-:602: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#602: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:645:
+		      !intel_de_read(display, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)),

-:709: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#709: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:821:
+			    is_dmc_evt_ctl_reg(display, dmc_id, dmc_info->mmioaddr[i]) ? " (EVT_CTL)" :

-:710: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#710: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:822:
+			    is_dmc_evt_htp_reg(display, dmc_id, dmc_info->mmioaddr[i]) ? " (EVT_HTP)" : "",

-:1168: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1168: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:1274:
+		   intel_de_read(display, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)));

total: 0 errors, 4 warnings, 0 checks, 1210 lines checked




More information about the Intel-xe mailing list