[PATCH v2 41/43] drm/xe/ggtt: Convert register access to use xe_mmio

Rodrigo Vivi rodrigo.vivi at intel.com
Tue Sep 10 18:09:01 UTC 2024


On Fri, Sep 06, 2024 at 05:08:30PM -0700, Matt Roper wrote:
> Stop using GT pointers for register access.
> 
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_ggtt.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index f3fca5565d32..0f4e778a7663 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -107,8 +107,10 @@ static unsigned int probe_gsm_size(struct pci_dev *pdev)
>  
>  static void ggtt_update_access_counter(struct xe_ggtt *ggtt)
>  {
> -	struct xe_gt *gt = XE_WA(ggtt->tile->primary_gt, 22019338487) ? ggtt->tile->primary_gt :
> -			   ggtt->tile->media_gt;
> +	struct xe_tile *tile = ggtt->tile;
> +	struct xe_gt *affected_gt = XE_WA(tile->primary_gt, 22019338487) ?
> +		tile->primary_gt : tile->media_gt;
> +	struct xe_mmio *mmio = &affected_gt->mmio;
>  	u32 max_gtt_writes = XE_WA(ggtt->tile->primary_gt, 22019338487) ? 1100 : 63;
>  	/*
>  	 * Wa_22019338487: GMD_ID is a RO register, a dummy write forces gunit
> @@ -118,7 +120,7 @@ static void ggtt_update_access_counter(struct xe_ggtt *ggtt)
>  	lockdep_assert_held(&ggtt->lock);
>  
>  	if ((++ggtt->access_count % max_gtt_writes) == 0) {
> -		xe_mmio_write32(gt, GMD_ID, 0x0);
> +		xe_mmio_write32(mmio, GMD_ID, 0x0);
>  		ggtt->access_count = 0;
>  	}
>  }
> -- 
> 2.45.2
> 


More information about the Intel-xe mailing list