✗ CI.checkpatch: warning for Fix device private page livelock on CPU fault

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 11 03:10:04 UTC 2024


== Series Details ==

Series: Fix device private page livelock on CPU fault
URL   : https://patchwork.freedesktop.org/series/138497/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a4b4054ef029e32d07154acac270ada3909e9cce
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Tue Sep 10 20:03:37 2024 -0700

    mm/migrate: Trylock device page in do_swap_page
    
    Avoid multiple CPU page faults to the same device page racing by locking
    the page in do_swap_page before taking an additional reference to the
    page. This prevents scenarios where multiple CPU page faults each take
    an extra reference to a device page, which could abort migration in
    folio_migrate_mapping. With the device page locked in do_swap_page, the
    migrate_vma_* functions need to be updated to avoid locking the
    fault_page argument.
    
    Prior to this change, a livelock scenario could occur in Xe's (Intel GPU
    DRM driver) SVM implementation if enough threads faulted the same device
    page.
    
    Cc: Philip Yang <Philip.Yang at amd.com>
    Cc: Felix Kuehling <felix.kuehling at amd.com>
    Cc: Christian König <christian.koenig at amd.com>
    Cc: Andrew Morton <akpm at linux-foundation.org>
    Suggessted-by: Simona Vetter <simona.vetter at ffwll.ch>
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 43852924969a3fbe93796d71bece8e5539aa4845 drm-intel
a4b4054ef029 mm/migrate: Trylock device page in do_swap_page
-:25: WARNING:BAD_SIGN_OFF: Non-standard signature: 'Suggessted-by:' - perhaps 'Suggested-by:'?
#25: 
Suggessted-by: Simona Vetter <simona.vetter at ffwll.ch>

-:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#180: FILE: mm/migrate_device.c:874:
+void migrate_device_finalize(unsigned long *src_pfns,
+			unsigned long *dst_pfns, unsigned long npages)

total: 0 errors, 1 warnings, 1 checks, 149 lines checked




More information about the Intel-xe mailing list