[PATCH] drm/xe/display: Remove dp_mst_suspend/resume from d3cold

Suraj Kandpal suraj.kandpal at intel.com
Wed Sep 11 12:48:21 UTC 2024


Remove intel_dp_mst_suspend/resume functions from d3cold_suspend/
resume. It is incorrect as it depends on AUX transfers which itself
depend on the device being runtime resumed. This is also why we see
a lock_dep splat here.

Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 61c8eb10a1b3..76c1365489bc 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -312,8 +312,6 @@ static void xe_display_to_d3cold(struct xe_device *xe)
 	 */
 	intel_power_domains_disable(xe);
 
-	intel_dp_mst_suspend(xe);
-
 	intel_hpd_cancel_work(xe);
 
 	intel_opregion_suspend(display, PCI_D3cold);
@@ -333,9 +331,6 @@ static void xe_display_from_d3cold(struct xe_device *xe)
 
 	intel_hpd_init(xe);
 
-	/* MST sideband requires HPD interrupts enabled */
-	intel_dp_mst_resume(xe);
-
 	intel_power_domains_enable(xe);
 }
 
-- 
2.43.2



More information about the Intel-xe mailing list