✗ CI.checkpatch: warning for drm/xe: Defer gt->mmio initialization until after multi-tile setup
Patchwork
patchwork at emeril.freedesktop.org
Tue Sep 17 22:22:04 UTC 2024
== Series Details ==
Series: drm/xe: Defer gt->mmio initialization until after multi-tile setup
URL : https://patchwork.freedesktop.org/series/138788/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 79c19d8efd2428c3d1efb286296bbcf16d1b14ce
Author: Matt Roper <matthew.d.roper at intel.com>
Date: Tue Sep 17 15:16:16 2024 -0700
drm/xe: Defer gt->mmio initialization until after multi-tile setup
With the recent xe_mmio redesign, tiles and GTs each have their own MMIO
accessor, with the GT inheriting some of the information (such as the
iomap pointer) from their containing tile. Given that non-root tiles
get initialized later than the root tile (and currently after the point
at which GT MMIO is initialized for _all_ GTs), we wind up incorrectly
inheriting uninitialized pointers for the initialization of GT MMIO for
GTs that reside on non-root tiles. This causes a driver crash on
multi-tile PVC platforms.
With the general xe_mmio redesign, it's now only necessary to do the
GT-level MMIO setup before the point we start reading/writing GT
registers. Move initialization of gt->mmio out of xe_info_init (which
runs before non-root tiles are initialized) and to the beginning of
where we start actually accessing the GTs themselves.
The high-level initialization flow now boils down to:
- General device init, software-only setup
- (no register access possible yet)
- Root tile initialization
- (access to device/tile0 registers possible via xe_root_tile_mmio())
- Initialization of non-root tiles
- (access to any tile's registers possible via tile->mmio)
- GT MMIO initialization, inheriting iomap from each GT's tile
- (access to any GT's registers possible via gt->mmio)
Fixes: fa599b8c95a7 ("drm/xe: Populate GT's mmio iomap from tile during init")
Reported-by: John Harrison <John.C.Harrison at Intel.com>
Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
+ /mt/dim checkpatch 38e1b615fb395b928e514108e908cd6edf3d34c3 drm-intel
79c19d8efd24 drm/xe: Defer gt->mmio initialization until after multi-tile setup
-:33: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#33:
Reported-by: John Harrison <John.C.Harrison at Intel.com>
Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
total: 0 errors, 1 warnings, 0 checks, 74 lines checked
More information about the Intel-xe
mailing list