✗ CI.checkpatch: warning for Modify iterators to prepare for ultrajoiner (rev2)

[Patchwork]

== Series Details ==

Series: Modify iterators to prepare for ultrajoiner (rev2)
URL   : https://patchwork.freedesktop.org/series/138750/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0758841bed3f055adea481f8e642c7cbd22d5ae5
Author: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
Date:   Wed Sep 18 12:00:16 2024 +0530

    drm/i915/display: Enhance iterators for modeset en/disable
    
    Joiners have specific enabling and disabling order dependent on primary
    and secondary pipes. This becomes more complex with ultrajoiner where we
    have ultrajoiner primary/secondary pipes in addition to bigjoiner
    primary/secondary pipes. To unify the approach that works for present
    and future joiner cases, use primary and secondary pipe masks to
    iterate over pipes.
    
    If joiner is used, derive bigoiner primary and secondary pipe masks
    and use following sequences:
    Disabling : disable primary pipes followed by secondary pipes,
    Enabling: enable secondary pipes followed by primary pipes.
    
    This works well with ultrajoiner too, as ultrajoiner has 2 bigjoiner
    primary/secondary pairs (AC, BD).
    
    For non joiner case, enable/disable based on usual pipe order A-D, D-A
    respectively.
    
    v2:
    -Simplify the iterator macro. (Ville)
    -Use struct intel_display. (Ville)
    -Add prefix _intel to the helper name. (Ville)
    
    Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
    Suggested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch a7c4f56f92ff668c90423c9601e213f1944ff09a drm-intel
7bd9cd281f90 drm/i915: Add some essential functionality for joiners
0758841bed3f drm/i915/display: Enhance iterators for modeset en/disable
-:203: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects?
#203: FILE: drivers/gpu/drm/i915/display/intel_display.h:395:
+#define for_each_crtc_in_masks(display, crtc, first_pipes, second_pipes, i) \
+	for ((i) = 0; \
+	     (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \
+	     (i)++) \
+		for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i))

-:203: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#203: FILE: drivers/gpu/drm/i915/display/intel_display.h:395:
+#define for_each_crtc_in_masks(display, crtc, first_pipes, second_pipes, i) \
+	for ((i) = 0; \
+	     (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \
+	     (i)++) \
+		for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i))

-:205: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#205: FILE: drivers/gpu/drm/i915/display/intel_display.h:397:
+	     (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \

-:209: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects?
#209: FILE: drivers/gpu/drm/i915/display/intel_display.h:401:
+#define for_each_crtc_in_masks_reverse(display, crtc, first_pipes, second_pipes, i) \
+	for ((i) = (I915_MAX_PIPES * 2 - 1); \
+	     (i) >= 0 && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \
+	     (i)--) \
+		for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i))

-:209: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#209: FILE: drivers/gpu/drm/i915/display/intel_display.h:401:
+#define for_each_crtc_in_masks_reverse(display, crtc, first_pipes, second_pipes, i) \
+	for ((i) = (I915_MAX_PIPES * 2 - 1); \
+	     (i) >= 0 && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \
+	     (i)--) \
+		for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i))

-:215: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc_state' - possible side-effects?
#215: FILE: drivers/gpu/drm/i915/display/intel_display.h:407:
+#define for_each_pipe_crtc_modeset_disable(display, crtc, crtc_state, i) \
+	for_each_crtc_in_masks(display, crtc, \
+			       _intel_modeset_primary_pipes(crtc_state), \
+			       _intel_modeset_secondary_pipes(crtc_state), \
+			       i)

-:221: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc_state' - possible side-effects?
#221: FILE: drivers/gpu/drm/i915/display/intel_display.h:413:
+#define for_each_pipe_crtc_modeset_enable(display, crtc, crtc_state, i) \
+	for_each_crtc_in_masks_reverse(display, crtc, \
+				       _intel_modeset_primary_pipes(crtc_state), \
+				       _intel_modeset_secondary_pipes(crtc_state), \
+				       i)

total: 0 errors, 1 warnings, 6 checks, 234 lines checked