✗ CI.checkpatch: warning for drm/i915: wakeref fixes and improvements

[Patchwork]

== Series Details ==

Series: drm/i915: wakeref fixes and improvements
URL   : https://patchwork.freedesktop.org/series/138811/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 581219fc3219909d3bac405a915e04ed5ccce0c7
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Wed Sep 18 14:17:48 2024 +0300

    drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
    
    For intel_wakeref_t, opaque is reasonable, but disguising the underlying
    struct ref_tracker * as an unsigned long is not so great. Update the
    typedef to remove one level of disguise.
    
    Although the kernel coding style strongly discourages pointer typedefs,
    it's a better alternative, and an incremental improvement on the status
    quo. It provides much better type safety than an unsigned long could,
    and prevents passing magic -1 instead of INTEL_WAKEREF_DEF. Moreover, it
    provides a gradual path for replacing intel_wakeref_t with struct
    ref_tracker * if desired.
    
    As an extra safety measure, check for error pointers in
    intel_ref_tracker_free() before passing them on to ref_tracker_free(),
    to catch any mistakes with mock gt special wakeref value.
    
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 3abb1f2faac15a9f09824d692d1a38e0c485dc6b drm-intel
25ce9d847013 drm/i915/gem: fix bitwise and logical AND mixup
761bf2442ebc drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t
d75806a5e6a7 drm/i915/gt: add a macro for mock gt wakeref special value and use it
81f09d33862d drm/i915/audio: be explicit about intel_wakeref_t conversions
581219fc3219 drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *
-:46: WARNING:NEW_TYPEDEFS: do not add new typedefs
#46: FILE: drivers/gpu/drm/i915/intel_wakeref.h:24:
+typedef struct ref_tracker *intel_wakeref_t;

-:93: WARNING:NEW_TYPEDEFS: do not add new typedefs
#93: FILE: drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:8:
+typedef struct ref_tracker *intel_wakeref_t;

total: 0 errors, 2 warnings, 0 checks, 56 lines checked