✗ CI.checkpatch: warning for PF: Add functions to save and restore VF configuration blob

[Patchwork]

== Series Details ==

Series: PF: Add functions to save and restore VF configuration blob
URL   : https://patchwork.freedesktop.org/series/138876/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c62d7e164862503a3662a095da1c6c9014248cb2
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5a4ef9a7169044765c3dab137da002a875f06f27
Author: Michal Wajdeczko <michal.wajdeczko at intel.com>
Date:   Thu Sep 19 19:15:28 2024 +0200

    drm/xe/pf: Allow to save and restore VF config blob from debugfs
    
    For feature enabling and testing purposes, allow to capture and
    replace full VF configuration using debugfs blob file, but only
    under strict debug config.
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
+ /mt/dim checkpatch 8fdbcd0d647cfca8f49da0c8cedb4053de87ec12 drm-intel
f343b548de53 drm/xe/guc: Add yet another helper macro for threshold
e866c1793816 drm/xe/pf: Update success code of pf_validate_vf_config()
660c20da7f81 drm/xe/pf: Allow to encode subset of VF configuration KLVs
896339b499f6 drm/xe/pf: Add functions to save and restore VF configuration blob
-:100: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'TAG' - possible side-effects?
#100: FILE: drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:2142:
+#define define_threshold_key_to_provision_case(TAG, ...)				\
+	case MAKE_GUC_KLV_VF_CFG_THRESHOLD_KEY(TAG):					\
+		BUILD_BUG_ON(MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG) != 1u);		\
+		if (len != MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG))			\
+			return -EBADMSG;						\
+		return pf_provision_threshold(gt, vfid,					\
+					      MAKE_XE_GUC_KLV_THRESHOLD_INDEX(TAG),	\
+					      value[0]);

-:100: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#100: FILE: drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:2142:
+#define define_threshold_key_to_provision_case(TAG, ...)				\
+	case MAKE_GUC_KLV_VF_CFG_THRESHOLD_KEY(TAG):					\
+		BUILD_BUG_ON(MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG) != 1u);		\
+		if (len != MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG))			\
+			return -EBADMSG;						\
+		return pf_provision_threshold(gt, vfid,					\
+					      MAKE_XE_GUC_KLV_THRESHOLD_INDEX(TAG),	\
+					      value[0]);

-:100: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#100: FILE: drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:2142:
+#define define_threshold_key_to_provision_case(TAG, ...)				\
+	case MAKE_GUC_KLV_VF_CFG_THRESHOLD_KEY(TAG):					\
+		BUILD_BUG_ON(MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG) != 1u);		\
+		if (len != MAKE_GUC_KLV_VF_CFG_THRESHOLD_LEN(TAG))			\
+			return -EBADMSG;						\
+		return pf_provision_threshold(gt, vfid,					\
+					      MAKE_XE_GUC_KLV_THRESHOLD_INDEX(TAG),	\
+					      value[0]);

total: 0 errors, 2 warnings, 1 checks, 192 lines checked
5a4ef9a71690 drm/xe/pf: Allow to save and restore VF config blob from debugfs