✗ CI.checkpatch: warning for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev3)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev3)
URL   : https://patchwork.freedesktop.org/series/137985/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0d67d21b69f7693efa8577a2dcd299f0c75a577e
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Thu Sep 19 20:21:08 2024 -0700

    drm/xe/guc: Add a helper function for dumping GuC log to dmesg
    
    Create a helper function that can be used to dump the GuC log to dmesg
    in a manner that is reliable for extraction and decode. The intention
    is that calls to this can be added by developers when debugging
    specific issues that require a GuC log but do not allow easy capture
    of the log - e.g. failures in selftests and failues that lead to
    kernel hangs.
    
    Also note that this is really a temporary stop-gap. The aim is to
    allow on demand creation and dumping of devcoredump captures (which
    includes the GuC log and much more). Currently this is not possible as
    much of the devcoredump code requires a 'struct xe_sched_job' and
    those are not available at many places that might want to do the dump.
    
    v2: Add kerneldoc - review feedback from Michal W.
    
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch d4340c1de6d417c7b3edac187c3af011b146701a drm-intel
33b043a9ad16 drm/xe/guc: Remove spurious line feed in debug print
d638e804b5bc drm/xe/devcoredump: Use drm_puts and already cached local variables
d90b83edfcfb drm/xe/devcoredump: Improve section headings and add tile info
601ff229b4fe drm/xe/devcoredump: Add ASCII85 dump helper function
b1b26a7f6a68 drm/xe/guc: Copy GuC log prior to dumping
49931055eb08 drm/xe/guc: Use a two stage dump for GuC logs and add more info
14ccb7c29eb5 drm/print: Introduce drm_line_printer
86e93b643bf3 drm/xe/guc: Dead CT helper
-:96: WARNING:MACRO_ARG_UNUSED: Argument 'ct' is not used in function-like macro
#96: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

-:96: WARNING:MACRO_ARG_UNUSED: Argument 'reason' is not used in function-like macro
#96: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

total: 0 errors, 2 warnings, 0 checks, 557 lines checked
a389d4b51624 drm/xe/guc: Dump entire CTB on errors
eb5023749064 drm/xe/guc: Add GuC log to devcoredump captures
0d67d21b69f7 drm/xe/guc: Add a helper function for dumping GuC log to dmesg