[PATCH 12/31] drm/i915: Remove lingering pci_save_state

Rodrigo Vivi rodrigo.vivi at intel.com
Tue Sep 24 20:35:33 UTC 2024


The pairing pci_restore_state was removed by commit
'b7e53aba2f0e ("drm/i915: remove restore in resume")'
to fix a hardware hang in resume.

Furthermore, it looks like PCI subsystem should be taking care
of the save and restore here.

Remove the lingering/stand-alone pci_save_state call.

Cc: Anshuman Gupta <anshuman.gupta at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 drivers/gpu/drm/i915/i915_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index ce2dd03136d3..4fc9d8bce1fd 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -1008,8 +1008,6 @@ static int i915_drm_suspend(struct drm_device *dev)
 		intel_display_driver_disable_user_access(dev_priv);
 	}
 
-	pci_save_state(pdev);
-
 	intel_display_driver_suspend(dev_priv);
 
 	intel_irq_suspend(dev_priv);
-- 
2.46.0



More information about the Intel-xe mailing list