✗ CI.checkpatch: warning for Ultrajoiner basic functionality series (rev3)

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 25 22:13:59 UTC 2024


== Series Details ==

Series: Ultrajoiner basic functionality series (rev3)
URL   : https://patchwork.freedesktop.org/series/138827/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dbbd2551522b01499500006cf1578286f5d80058
Author: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
Date:   Mon Sep 23 23:43:36 2024 +0530

    drm/i915/intel_dp: Add support for forcing ultrajoiner
    
    Allow forcing ultrajoiner through debugfs.
    
    v2: Minor refactoring of switch case logic. (Ville)
    
    Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
    Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>
    Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch 88d592f72f7bc508d6a027b1f96aa2e53f803e1b drm-intel
6dfe0f77552c drm/i915/display_device: Add Check HAS_DSC for bigjoiner
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:121:
+#define HAS_BIGJOINER(i915)		(DISPLAY_VER(i915) >= 11 && HAS_DSC(i915))

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
76d9f939063e drm/i915/display_debugfs: Allow force joiner only if supported
f04f32d53edf drm/i915/display: Modify debugfs for joiner to force n pipes
c4158e370196 drm/i915/dp: Add helper to compute num pipes required
-:101: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#101: FILE: drivers/gpu/drm/i915/display/intel_dp.c:2520:
+	num_joined_pipes = intel_dp_num_joined_pipes(intel_dp, connector,
+						      adjusted_mode->crtc_hdisplay,

-:120: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#120: FILE: drivers/gpu/drm/i915/display/intel_dp.h:155:
+int intel_dp_num_joined_pipes(struct intel_dp *intel_dp,
+			       struct intel_connector *connector,

-:140: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#140: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:585:
+	num_joined_pipes = intel_dp_num_joined_pipes(intel_dp, connector,
+						      adjusted_mode->crtc_hdisplay,

-:168: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#168: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:1475:
+	num_joined_pipes = intel_dp_num_joined_pipes(intel_dp, intel_connector,
+						      mode->hdisplay, target_clock);

total: 0 errors, 0 warnings, 4 checks, 129 lines checked
c45a9722ceb7 drm/i915/display: Add debugfs support to avoid joiner
4f8f8330cae9 drm/i915: Split current joiner hw state readout
b60b17275207 drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks
9d72fb4d6a85 drm/i915/display: Add macro HAS_ULTRAJOINER()
-:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#26: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:157:
+#define HAS_ULTRAJOINER(i915)		((DISPLAY_VER(i915) >= 20 || \
+					  (IS_DGFX(i915) && DISPLAY_VER(i915) == 14)) && \
+					 HAS_DSC(i915))

total: 0 errors, 0 warnings, 1 checks, 9 lines checked
5b1897a8aa54 drm/i915: Implement hw state readout and checks for ultrajoiner
7b49f6e4a5c8 drm/i915/display: Refactor enable_joiner_pipes
-:80: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#80: FILE: drivers/gpu/drm/i915/display/intel_display.c:3798:
+			expected_uncompressed_joiner_secondary_pipes(primary_uncompressed_joiner_pipes);

total: 0 errors, 1 warnings, 0 checks, 120 lines checked
e24d993eaa19 drm/i915/display/vdsc: Add ultrajoiner support with DSC
e2d5f5b7f0c5 drm/i915/dp: Modify compressed bpp limitations for ultrajoiner
2f8056f9c0f3 drm/i915/dp: Modify helper to get slice count for ultrajoiner
1bd121b755b9 drm/i915: Compute config and mode valid changes for ultrajoiner
03125bc4623a drm/i915/display: Consider ultrajoiner for computing maxdotclock
dbbd2551522b drm/i915/intel_dp: Add support for forcing ultrajoiner




More information about the Intel-xe mailing list