✓ CI.checkpatch: success for drm/xe/guc_submit: add missing locking in wedged_fini
Patchwork
patchwork at emeril.freedesktop.org
Thu Sep 26 01:48:00 UTC 2024
== Series Details ==
Series: drm/xe/guc_submit: add missing locking in wedged_fini
URL : https://patchwork.freedesktop.org/series/139055/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1a3349abc863d50aad3f21c4df576cc2c365a6a4
Author: Matthew Auld <matthew.auld at intel.com>
Date: Tue Sep 24 16:09:48 2024 +0100
drm/xe/guc_submit: add missing locking in wedged_fini
Any non-wedged queue can have a zero refcount here and can be running
concurrently with an async queue destroy, therefore dereferencing the
queue ptr to check wedge status after the lookup can trigger UAF if
queue is not wedged. Fix this by keeping the submission_state lock held
around the check to postpone the free and make the check safe, before
dropping again around the put() to avoid the deadlock.
Fixes: 8ed9aaae39f3 ("drm/xe: Force wedged state and block GT reset upon any GPU hang")
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 88d592f72f7bc508d6a027b1f96aa2e53f803e1b drm-intel
1a3349abc863 drm/xe/guc_submit: add missing locking in wedged_fini
More information about the Intel-xe
mailing list