✓ CI.checkpatch: success for drm/xe: Take ref to job and job's fence in xe_sched_job_arm (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Sep 26 03:51:27 UTC 2024
== Series Details ==
Series: drm/xe: Take ref to job and job's fence in xe_sched_job_arm (rev2)
URL : https://patchwork.freedesktop.org/series/138939/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5e3ae1af765850079897dbd3c850532ecdb5af70
Author: Matthew Brost <matthew.brost at intel.com>
Date: Tue Sep 24 11:45:41 2024 -0700
drm/xe: Take ref to job and job's fence in xe_sched_job_arm
Fixes two possible races:
- Submission to hardware signals job's fence before dma_fence_get at end
of run_job
- TDR fires and signals fence + free job before run_job completes
Taking refs in xe_sched_job_arm to job and job's fence solves these by
ensure all refs collected before entering the DRM scheduler. The refs
are dropped in run_job and DRM scheduler respectfully. Safe as once
xe_sched_job_arm is called execution of job through DRM sched is
guaranteed.
v2:
- Take job ref on resubmit (Matt Auld)
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2811
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: <stable at vger.kernel.org> # v6.8+
+ /mt/dim checkpatch 88d592f72f7bc508d6a027b1f96aa2e53f803e1b drm-intel
5e3ae1af7658 drm/xe: Take ref to job and job's fence in xe_sched_job_arm
More information about the Intel-xe
mailing list