[PATCH v2] drm/xe: Add the missed value paramter of LE_COS

[Lin, Shuicheng]

On Tue, Apr 01, 2025 at 2:29 PM, Roper, Matthew D wrote:
> On Tue, Apr 01, 2025 at 08:57:03PM +0000, Shuicheng Lin wrote:
> > value is missed for LE_COS
> >
> > Cc: Matt Roper <matthew.d.roper at intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
> > ---
> >  drivers/gpu/drm/xe/regs/xe_gt_regs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > index da1f198ac107..042c8401aee9 100644
> > --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > @@ -62,7 +62,7 @@
> >  #define   LE_SSE_MASK				REG_GENMASK(18,
> 17)
> >  #define   LE_SSE(value)
> 	REG_FIELD_PREP(LE_SSE_MASK, value)
> >  #define   LE_COS_MASK				REG_GENMASK(16,
> 15)
> > -#define   LE_COS(value)
> 	REG_FIELD_PREP(LE_COS_MASK)
> > +#define   LE_COS(value)
> 	REG_FIELD_PREP(LE_COS_MASK, value)
> 
> It looks like this definition was added in commit 9fbd0adbcbe8
> ("drm/xe/mocs: Add debugfs node to dump mocs") but has never been used
> anywhere in the driver (which is why we didn't have a build error).  The value
> for this field is universally "0" for every MOCS entry on the old Xe_LP
> platforms, and the whole field has been removed from Xe_HP onward.
> So it might make more sense to just delete the line so that we don't have an
> unused definition.
> 
> 
> Matt
I am OK to remove it. I just have a check with other definitions nearby, and some
of them are not used also (LE_SCF, LE_PFM etc). It makes me prefer to keep the
definition. Otherwise, it likes a hole, only this BIT is not defined.
What is your idea about it? Thanks.

Shuicheng
> 
> >  #define   LE_SCF_MASK				REG_BIT(14)
> >  #define   LE_SCF(value)
> 	REG_FIELD_PREP(LE_SCF_MASK, value)
> >  #define   LE_PFM_MASK				REG_GENMASK(13,
> 11)
> > --
> > 2.25.1
> >
> 
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation