[PATCH 08/10] drm/i915/hdmi: Use an intel_connector pointer everywhere

Imre Deak imre.deak at intel.com
Wed Apr 9 14:01:20 UTC 2025


On Wed, Apr 09, 2025 at 11:29:30AM +0300, Jani Nikula wrote:
> On Wed, 09 Apr 2025, Imre Deak <imre.deak at intel.com> wrote:
> > Following the convention, convert intel_hdmi.c to use an intel_connector
> > pointer everywhere, calling this pointer connector. If the intel
> > connector must be casted from a drm_connector, call this pointer
> > _connector and use this pointer only for the casting.
> >
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> 
> > @@ -2076,14 +2081,16 @@ bool intel_hdmi_bpc_possible(const struct intel_crtc_state *crtc_state,
> >  {
> >  	struct drm_atomic_state *state = crtc_state->uapi.state;
> >  	struct drm_connector_state *connector_state;
> > -	struct drm_connector *connector;
> > +	struct drm_connector *_connector;
> >  	int i;
> >  
> > -	for_each_new_connector_in_state(state, connector, connector_state, i) {
> > +	for_each_new_connector_in_state(state, _connector, connector_state, i) {
> 
> Can we use for_each_new_intel_connector_in_state() here?

Ok, can use it.

It depends on 'base' being the first field in
intel_digital_connector_state, I think that assumption is acceptable
(and used elsewhere already).

> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel


More information about the Intel-xe mailing list