✗ CI.checkpatch: warning for drm/{i915,xe}: Move PCH stuff under display

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 11 10:00:48 UTC 2025


== Series Details ==

Series: drm/{i915,xe}: Move PCH stuff under display
URL   : https://patchwork.freedesktop.org/series/147580/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
13a92ce9fd458ebd6064f23cec8c39c53d02ed26
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 945fc51a19d07eec4bc1bb8022c7b5632285adf9
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Fri Apr 11 12:54:14 2025 +0300

    drm/i915/pch: clean up includes
    
    We no longer need i915_drv.h in intel_pch.c, and we no longer need
    intel_pch.h universally.
    
    With intel_pch.h being included from intel_display_core.h, it's still
    included pretty much everywhere, but there's no need to include it
    explicitly from i915_drv.h or xe_device_types.h.
    
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 24cf8a809b44d0ab872b5fc4a364a30f0ab7960f drm-intel
ea1ad6e1065d drm/{i915,xe}: Move intel_pch under display
-:38: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
rename from drivers/gpu/drm/i915/soc/intel_pch.c

total: 0 errors, 1 warnings, 0 checks, 65 lines checked
1125031ff899 drm/i915/display: Convert intel_pch towards intel_display
-:473: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'display' - possible side-effects?
#473: FILE: drivers/gpu/drm/i915/display/intel_pch.h:49:
+#define HAS_PCH_LPT(display)			(INTEL_PCH_TYPE(display) == PCH_LPT_H || \
+						 INTEL_PCH_TYPE(display) == PCH_LPT_LP)

total: 0 errors, 0 warnings, 1 checks, 474 lines checked
260974a9bfa3 drm/i915/pch: move PCH detection to intel_display_driver_early_probe()
945fc51a19d0 drm/i915/pch: clean up includes




More information about the Intel-xe mailing list