[PATCH 2/2] drm/xe: Use GT oriented message to report engine activity error

[Riana Tauro]

On 4/15/2025 1:53 AM, Michal Wajdeczko wrote:
> We are enabling/disabling engine activity on per-GT basis, so any
> errors should be also reported per GT, like:
> 
>   [ ] xe 0000:00:02.0: [drm] GT0: PF: Failed to enable engine activity function stats (-ENOSPC)
>   [ ] xe 0000:00:02.0: [drm] GT1: PF: Failed to enable engine activity function stats (-ENOSPC)
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro at intel.com>> Cc: Umesh Nerlige 
Ramappa <umesh.nerlige.ramappa at intel.com>
> Cc: Riana Tauro <riana.tauro at intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pci_sriov.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci_sriov.c b/drivers/gpu/drm/xe/xe_pci_sriov.c
> index d69b6b2a3061..8813efdcafbb 100644
> --- a/drivers/gpu/drm/xe/xe_pci_sriov.c
> +++ b/drivers/gpu/drm/xe/xe_pci_sriov.c
> @@ -7,6 +7,7 @@
>   #include "xe_device.h"
>   #include "xe_gt_sriov_pf_config.h"
>   #include "xe_gt_sriov_pf_control.h"
> +#include "xe_gt_sriov_printk.h"
>   #include "xe_guc_engine_activity.h"
>   #include "xe_pci_sriov.h"
>   #include "xe_pm.h"
> @@ -121,8 +122,8 @@ static void pf_engine_activity_stats(struct xe_device *xe, unsigned int num_vfs,
>   	for_each_gt(gt, xe, id) {
>   		ret = xe_guc_engine_activity_function_stats(&gt->uc.guc, num_vfs, enable);
>   		if (ret)
> -			xe_sriov_info(xe, "Failed to %s engine activity function stats (%pe)\n",
> -				      str_enable_disable(enable), ERR_PTR(ret));
> +			xe_gt_sriov_info(gt, "Failed to %s engine activity function stats (%pe)\n",
> +					 str_enable_disable(enable), ERR_PTR(ret));
>   	}
>   }
>