[PATCH 1/2] drm/xe: Introduce fault injection for guc mmio send/recv.

[Michal Wajdeczko]

On 03.04.2025 14:06, Satyanarayana K V P wrote:
> Fault can be injected with below steps.
> 
> FAILTYPE=fail_function
> FAILFUNC=xe_guc_mmio_send_recv
> 
> echo > /sys/kernel/debug/$FAILTYPE/inject
> echo $FAILFUNC > /sys/kernel/debug/$FAILTYPE/inject
> printf %#x -5 > /sys/kernel/debug/$FAILTYPE/$FAILFUNC/retval
> 
> echo N > /sys/kernel/debug/$FAILTYPE/task-filter
> echo 10 > /sys/kernel/debug/$FAILTYPE/probability
> echo 0 > /sys/kernel/debug/$FAILTYPE/interval
> echo -1 > /sys/kernel/debug/$FAILTYPE/times
> echo 0 > /sys/kernel/debug/$FAILTYPE/space
> echo 1 > /sys/kernel/debug/$FAILTYPE/verbose

nit: IMO without FAILTYPE var it would look simpler

> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>
> Cc: Michał Wajdeczko <michal.wajdeczko at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index bc5714a5b36b..ca0823df252e 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -1393,6 +1393,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
>  	/* Use data from the GuC response as our return value */
>  	return FIELD_GET(GUC_HXG_RESPONSE_MSG_0_DATA0, header);
>  }
> +ALLOW_ERROR_INJECTION(xe_guc_mmio_send_recv, ERRNO);
>  
>  int xe_guc_mmio_send(struct xe_guc *guc, const u32 *request, u32 len)
>  {

but still LGTM,

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>