[PATCH] drm/xe/ring_ops_types: Increase MAX_JOB_SIZE_DW

[Matthew Brost]

On Tue, Apr 15, 2025 at 01:57:29PM +0200, Francois Dugast wrote:
> On Tue, Apr 15, 2025 at 12:45:04PM +0100, Tvrtko Ursulin wrote:
> > 
> > Hi,
> > 
> > On 15/04/2025 12:15, Francois Dugast wrote:
> > > This limit can be hit, for example when running IGT compute-square on MTL:
> > > 
> > >      [   63.582385] xe 0000:00:02.0: [drm] Assertion `i <= 48` failed!
> > >                     platform: METEORLAKE subplatform: 1
> > >                     graphics: Xe_LPG 12.71 step B0
> > >                     media: Xe_LPM+ 13.00 step C0
> > >                     tile: 0 VRAM 0 B
> > >                     GT: 0 type 1
> > >      [   63.582408] WARNING: CPU: 0 PID: 2439 at drivers/gpu/drm/xe/xe_ring_ops.c:395 __emit_job_gen12_render_compute+0xa7c/0xc70 [xe]
> > > 
> > > Increase the value to allow this test to pass.
> > > 
> > > Signed-off-by: Francois Dugast <francois.dugast at intel.com>
> > > ---
> > >   drivers/gpu/drm/xe/xe_ring_ops_types.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_ring_ops_types.h b/drivers/gpu/drm/xe/xe_ring_ops_types.h
> > > index 1ae56e2ee7b4..121279c826eb 100644
> > > --- a/drivers/gpu/drm/xe/xe_ring_ops_types.h
> > > +++ b/drivers/gpu/drm/xe/xe_ring_ops_types.h
> > > @@ -8,7 +8,7 @@
> > >   struct xe_sched_job;
> > > -#define MAX_JOB_SIZE_DW 48
> > > +#define MAX_JOB_SIZE_DW 64
> > >   #define MAX_JOB_SIZE_BYTES (MAX_JOB_SIZE_DW * 4)
> > >   /**
> > 
> > I've sent the same fix two weeks ago:
> > 
> > https://patchwork.freedesktop.org/patch/646815/?series=144186&rev=5
> > 
> > I hand counted 58 dwords is enough. You think I undercounted?
> 
> This seems right and I confirm it is sufficient to solve the issue I
> described in my commit message, so let's go with your version.
> 

Either patch LGTM. Do we need a fixes tag though for backporting?

Matt

> Thanks,
> Francois
> 
> > 
> > Regards,
> > 
> > Tvrtko
> >