[PATCH 1/2] drm/xe: s/tlb_invalidation.lock/tlb_invalidation.fence_lock
Summers, Stuart
stuart.summers at intel.com
Wed Apr 16 19:23:17 UTC 2025
On Wed, 2025-04-16 at 18:30 +0000, Stuart Summers wrote:
> From: Matthew Brost <matthew.brost at intel.com>
>
> tlb_invalidation.lock is the lock for GT TLB invalidation fences,
> name
> this accurately.
>
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
This one makes sense to me and I'm happy to add my:
Reviewed-by: Stuart Summers <stuart.summers at intel.com>
But given I posted, maybe good to have one more on here?
Thanks,
Stuart
> ---
> drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 8 ++++----
> drivers/gpu/drm/xe/xe_gt_types.h | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index 084cbdeba8ea..031c4d43f36b 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -119,7 +119,7 @@ int xe_gt_tlb_invalidation_init_early(struct
> xe_gt *gt)
> gt->tlb_invalidation.seqno = 1;
> INIT_LIST_HEAD(>->tlb_invalidation.pending_fences);
> spin_lock_init(>->tlb_invalidation.pending_lock);
> - spin_lock_init(>->tlb_invalidation.lock);
> + spin_lock_init(>->tlb_invalidation.fence_lock);
> INIT_DELAYED_WORK(>->tlb_invalidation.fence_tdr,
> xe_gt_tlb_fence_timeout);
>
> @@ -564,11 +564,11 @@ void xe_gt_tlb_invalidation_fence_init(struct
> xe_gt *gt,
> {
> xe_pm_runtime_get_noresume(gt_to_xe(gt));
>
> - spin_lock_irq(>->tlb_invalidation.lock);
> + spin_lock_irq(>->tlb_invalidation.fence_lock);
> dma_fence_init(&fence->base, &invalidation_fence_ops,
> - >->tlb_invalidation.lock,
> + >->tlb_invalidation.fence_lock,
> dma_fence_context_alloc(1), 1);
> - spin_unlock_irq(>->tlb_invalidation.lock);
> + spin_unlock_irq(>->tlb_invalidation.fence_lock);
> INIT_LIST_HEAD(&fence->link);
> if (stack)
> set_bit(FENCE_STACK_BIT, &fence->base.flags);
> diff --git a/drivers/gpu/drm/xe/xe_gt_types.h
> b/drivers/gpu/drm/xe/xe_gt_types.h
> index 7def0959da35..be81687cbe2b 100644
> --- a/drivers/gpu/drm/xe/xe_gt_types.h
> +++ b/drivers/gpu/drm/xe/xe_gt_types.h
> @@ -210,8 +210,8 @@ struct xe_gt {
> * xe_gt_tlb_fence_timeout after the timeut interval
> is over.
> */
> struct delayed_work fence_tdr;
> - /** @tlb_invalidation.lock: protects TLB invalidation
> fences */
> - spinlock_t lock;
> + /** @tlb_invalidation.fence_lock: protects TLB
> invalidation fences */
> + spinlock_t fence_lock;
> } tlb_invalidation;
>
> /**
More information about the Intel-xe
mailing list