[PATCH] drm/xe: xe_svm_range_alloc should return NULL upon error

[Upadhyay, Tejas]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Dafna
> Hirschfeld
> Sent: 22 April 2025 10:36
> To: intel-xe at lists.freedesktop.org
> Cc: Hirschfeld, Dafna <dafna.hirschfeld at intel.com>; Brost, Matthew
> <matthew.brost at intel.com>
> Subject: [PATCH] drm/xe: xe_svm_range_alloc should return NULL upon error
> 
> replace error pointer with NULL upon failure.
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> index c7424c824a14..d927f50f2a68 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
> @@ -80,7 +80,7 @@ xe_svm_range_alloc(struct drm_gpusvm *gpusvm)
> 
>  	range = kzalloc(sizeof(*range), GFP_KERNEL);
>  	if (!range)
> -		return ERR_PTR(-ENOMEM);

Yes drm_gpusvm_range_alloc expects NULL and then it returns error pointer. So LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

Tejas
> +		return NULL;
> 
>  	INIT_LIST_HEAD(&range->garbage_collector_link);
>  	xe_vm_get(gpusvm_to_vm(gpusvm));
> --
> 2.34.1