[PATCH] drm/gpusvm: remove unused pages pointer

Matthew Brost matthew.brost at intel.com
Tue Apr 22 15:19:58 UTC 2025


On Tue, Apr 22, 2025 at 12:59:43PM +0300, Dafna Hirschfeld wrote:
> the pages pointer is not used, remove it
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> ---
>  drivers/gpu/drm/drm_gpusvm.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
> index 2451c816edd5..30408f2dd370 100644
> --- a/drivers/gpu/drm/drm_gpusvm.c
> +++ b/drivers/gpu/drm/drm_gpusvm.c
> @@ -1330,7 +1330,6 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
>  	unsigned long num_dma_mapped;
>  	unsigned int order = 0;
>  	unsigned long *pfns;
> -	struct page **pages;
>  	int err = 0;
>  	struct dev_pagemap *pagemap;
>  	struct drm_pagemap *dpagemap;
> @@ -1368,8 +1367,6 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
>  	mmput(mm);
>  	if (err)
>  		goto err_free;
> -
> -	pages = (struct page **)pfns;
>  map_pages:
>  	/*
>  	 * Perform all dma mappings under the notifier lock to not
> @@ -1444,8 +1441,6 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
>  				err = -EFAULT;
>  				goto err_unmap;
>  			}
> -
> -			pages[i] = page;
>  		} else {
>  			dma_addr_t addr;
>  
> -- 
> 2.34.1
> 


More information about the Intel-xe mailing list