[PATCH] drm/xe/tests/mocs: Hold XE_FORCEWAKE_ALL for LNCF regs

[Ghimiray, Himal Prasad]

On 09-04-2025 11:58, Tejas Upadhyay wrote:
> LNCF registers report wrong values when XE_FORCEWAKE_GT
> only is held. Holding XE_FORCEWAKE_ALL ensures correct
> operations on LNCF regs.
> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1999
> Fixes: a6a4ea6d7d37 ("drm/xe: Add mocs kunit")
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>   drivers/gpu/drm/xe/tests/xe_mocs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_mocs.c b/drivers/gpu/drm/xe/tests/xe_mocs.c
> index ef1e5256c56a..cce7ebf5df72 100644
> --- a/drivers/gpu/drm/xe/tests/xe_mocs.c
> +++ b/drivers/gpu/drm/xe/tests/xe_mocs.c
> @@ -46,7 +46,7 @@ static void read_l3cc_table(struct xe_gt *gt,
>   	unsigned int fw_ref, i;
>   	u32 reg_val;
>   
> -	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
> +	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>   	KUNIT_ASSERT_NE_MSG(test, fw_ref, 0, "Forcewake Failed.\n");


For XE_FORCEWAKE_ALL fw_ref !=0 doesn't signify all domains are 
force_waked succesfully. please use xe_force_wake_ref_has_domain(fw_ref, 
XE_FORCEWAKE_ALL)

/Himal


>   
>   	for (i = 0; i < info->num_mocs_regs; i++) {