[PATCH 0/6] drm/i915: refactor VLV IOSF SB for display usage

Jani Nikula jani.nikula at intel.com
Fri Apr 25 13:19:18 UTC 2025


In short, add and use generic (not unit specific) read/write/get/put for
i915 core, move the unit specific helpers to display, and convert all of
them to use drm_display instead of drm_i915_private. This reduces the
display<->i915 interface to just a handful of functions, while keeping
the simple helpers in display where they are most commonly used.


Jani Nikula (6):
  drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch]
  drm/i915: add generic read/write functions for VLV IOSF SB
  drm/i915: rewrite VLV IOSF SB unit specific read/write functions
  drm/i915: switch i915 core to generic VLV IOSF SB functions
  drm/i915: move VLV IOSF SB unit specific helpers under display
  drm/i915: convert VLV IOSF SB interface to struct drm_device

 drivers/gpu/drm/i915/Makefile                 |   5 +-
 drivers/gpu/drm/i915/display/i9xx_wm.c        |  35 ++-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  47 ++---
 drivers/gpu/drm/i915/display/intel_display.c  |  23 +-
 drivers/gpu/drm/i915/display/intel_display.h  |   7 +-
 .../drm/i915/display/intel_display_power.c    |   7 +-
 .../i915/display/intel_display_power_map.c    |   2 +-
 .../i915/display/intel_display_power_well.c   |  71 +++----
 drivers/gpu/drm/i915/display/intel_dpio_phy.c | 199 +++++++++---------
 drivers/gpu/drm/i915/display/intel_dpll.c     | 135 ++++++------
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  26 ++-
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c    |  46 ++--
 drivers/gpu/drm/i915/display/vlv_sideband.c   |  50 +++++
 drivers/gpu/drm/i915/display/vlv_sideband.h   | 156 ++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c |   8 +-
 drivers/gpu/drm/i915/gt/intel_rps.c           |  58 ++---
 drivers/gpu/drm/i915/i915_driver.c            |   2 +-
 drivers/gpu/drm/i915/intel_clock_gating.c     |   2 +-
 drivers/gpu/drm/i915/soc/intel_dram.c         |  14 +-
 .../i915/{vlv_sideband.c => vlv_iosf_sb.c}    | 166 ++++++---------
 drivers/gpu/drm/i915/vlv_iosf_sb.h            |  37 ++++
 .../{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} |   6 +-
 drivers/gpu/drm/i915/vlv_sideband.h           | 125 -----------
 .../drm/xe/compat-i915-headers/vlv_iosf_sb.h  |  42 ++++
 .../{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} |   2 +-
 .../drm/xe/compat-i915-headers/vlv_sideband.h | 132 ------------
 26 files changed, 678 insertions(+), 725 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/vlv_sideband.c
 create mode 100644 drivers/gpu/drm/i915/display/vlv_sideband.h
 rename drivers/gpu/drm/i915/{vlv_sideband.c => vlv_iosf_sb.c} (56%)
 create mode 100644 drivers/gpu/drm/i915/vlv_iosf_sb.h
 rename drivers/gpu/drm/i915/{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} (98%)
 delete mode 100644 drivers/gpu/drm/i915/vlv_sideband.h
 create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h
 rename drivers/gpu/drm/xe/compat-i915-headers/{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} (66%)
 delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_sideband.h

-- 
2.39.5



More information about the Intel-xe mailing list