✗ CI.checkpatch: warning for Introducing firmware late binding

[Patchwork]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/148394/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6e9db086377bd8a1d71b4f4505aca1a304b53bb7
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Tue Apr 29 13:08:04 2025 +0530

    {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl
    
    Xe PCODE FWCTL implements the generic FWCTL IOCLTs to allow limited
    access from user space (as admin) to some very specific PCODE
    Mailboxes only related to hardware configuration.
    
    PCODE is a Firmware in Intel GPUs which is the main responsible
    component for power and thermal aspects of the Intel GPUs.
    
    Each different Intel GPU came with different PCODE versions with
    different mailboxes and different needs. In the lack of an unified
    interface, the per platform sysfs entries at the device level is
    trending to grow, to allow admins to control different aspects of
    the Hardware.
    
    In this first experiment, xe_pcode_fwctl only adds support for the
    Battlemage late-binding firmware information.
    
    Late-binding is the name given to 2 other new auxiliary firmware
    blobs that for now lives in the Flash like PCODE, but that soon
    it is coming to linux-firmware.git: Fan-controller and
    Voltage-regulator. Then, PCODE provides some mailboxes where the
    status of both late-binding firmware can be queried as specified
    in the documentation that is added along with the new uAPI here.
    
    RFC IMPORTANT NOTE:
    
    ===================
    Admins will need to query this information. This code here aims
    to be used by Level0-Sysman and/or Intel XPU Manager directly
    from user space. But following the drm upstream rules, the
    userspace code will need to be ready before we can consider
    getting this patch merged!
    
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>
+ /mt/dim checkpatch 2653f1a7089beef2da70293be1226983a979e918 drm-intel
5026d9d5292c mei: late_bind: add late binding component driver
-:37: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

-:45: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol with at least 4 lines
#45: FILE: drivers/misc/mei/late_bind/Kconfig:4:
+config INTEL_MEI_LATE_BIND
+	tristate "Intel late binding support on ME Interface"
+	select INTEL_MEI_ME
+	depends on DRM_XE
+	help
+	  MEI Support for Late Binding for Intel graphics card.
+
+	  Enables the ME FW interfaces for Late Binding for
+          Xe display driver of Intel.

-:217: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'mei_late_bind_push_config', this function's name, in a string
#217: FILE: drivers/misc/mei/late_bind/mei_late_bind.c:143:
+	dev_dbg(dev, "mei_late_bind_push_config status = %d\n", ret);

-:261: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#261: FILE: drivers/misc/mei/late_bind/mei_late_bind.c:187:
+static int mei_late_bind_component_match(struct device *dev, int subcomponent,
+				   void *data)

-:291: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#291: FILE: drivers/misc/mei/late_bind/mei_late_bind.c:217:
+static int mei_late_bind_probe(struct mei_cl_device *cldev,
+			 const struct mei_cl_device_id *id)

total: 0 errors, 3 warnings, 2 checks, 351 lines checked
1a994e34ad99 mei: bus: add mei_cldev_mtu interface
6c54f28ef5ee drm/xe/late_bind_fw: Introducing late_bind_fw
-:81: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#81: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 260 lines checked
d8384911aaa8 drm/xe/xe_late_bind_fw: Initialize late binding firmware
3677fe5a2bb7 drm/xe/xe_late_bind_fw: Load late binding firmware
df915ff55caf drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume
0833eb91225a drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume
9e51e744487f drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding
6e9db086377b {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl
-:98: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

-:192: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#192: FILE: drivers/gpu/drm/xe/xe_pcode_fwctl.c:90:
+DEFINE_FREE(xe_pcode_fwctl, struct xe_pcode_fwctl_dev *, if (_T) fwctl_put(&_T->fwctl))
[...]
+static int xe_pcode_fwctl_uctx_open(struct fwctl_uctx *uctx)

total: 0 errors, 2 warnings, 0 checks, 353 lines checked