[PATCH] drm/xe: fix stale comment about unordered_wq usage

Rodrigo Vivi rodrigo.vivi at intel.com
Fri Aug 1 21:08:49 UTC 2025


On Fri, Aug 01, 2025 at 12:28:05PM +0300, Jani Nikula wrote:
> On Thu, 31 Jul 2025, Jani Nikula <jani.nikula at intel.com> wrote:
> > Display has switched to its own workqueue, no longer using
> > xe->unordered_wq.
> 
> Lucas, Rodrigo, the change was done in 7c377900772d ("drm/i915/display:
> move unordered works to new private workqueue"), which is in drm-next
> and Linus' upstream but not in drm-xe-next yet. It's a minor detail, but
> do you care if this patch gets merged to xe before the backmerge with
> that?

I don't have any issue myself with cherry-picking that to avoid us having to
wait couple weeks until we reconcile the branches, if that is needed to
unblock any of your display clean-ups.

Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> 
> BR,
> Jani.
> 
> 
> >
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_device_types.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> > index 38c8329b4d2c..01e8fa0d2f9f 100644
> > --- a/drivers/gpu/drm/xe/xe_device_types.h
> > +++ b/drivers/gpu/drm/xe/xe_device_types.h
> > @@ -427,7 +427,7 @@ struct xe_device {
> >  	/** @ordered_wq: used to serialize compute mode resume */
> >  	struct workqueue_struct *ordered_wq;
> >  
> > -	/** @unordered_wq: used to serialize unordered work, mostly display */
> > +	/** @unordered_wq: used to serialize unordered work */
> >  	struct workqueue_struct *unordered_wq;
> >  
> >  	/** @destroy_wq: used to serialize user destroy work, like queue */
> 
> -- 
> Jani Nikula, Intel


More information about the Intel-xe mailing list