[PATCH v5 04/11] drm/xe/configfs: Drop redundant init() error message

Lucas De Marchi lucas.demarchi at intel.com
Tue Aug 5 12:55:12 UTC 2025


On Tue, Jul 29, 2025 at 01:42:08PM +0200, Michal Wajdeczko wrote:
>There is no need to print separate error message since we will
>also print one in xe_init(). Also drop temporary variable, which
>was likely just taken from the example code.
>
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_configfs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
>index 56fbf4c1c37f..6aa0531bcf76 100644
>--- a/drivers/gpu/drm/xe/xe_configfs.c
>+++ b/drivers/gpu/drm/xe/xe_configfs.c
>@@ -392,15 +392,12 @@ u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev)
>
> int __init xe_configfs_init(void)
> {
>-	struct config_group *root = &xe_configfs.su_group;
> 	int ret;
>
>-	config_group_init(root);
>+	config_group_init(&xe_configfs.su_group);
> 	mutex_init(&xe_configfs.su_mutex);
> 	ret = configfs_register_subsystem(&xe_configfs);
> 	if (ret) {
>-		pr_err("Error %d while registering %s subsystem\n",
>-		       ret, root->cg_item.ci_namebuf);
> 		mutex_destroy(&xe_configfs.su_mutex);
> 		return ret;
> 	}
>-- 
>2.47.1
>


More information about the Intel-xe mailing list