[PATCH 18/19] drm/i915/tc: Cache the pin assignment value

Kahola, Mika mika.kahola at intel.com
Fri Aug 8 08:27:49 UTC 2025


> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Imre Deak
> Sent: Tuesday, 5 August 2025 10.37
> To: intel-gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
> Subject: [PATCH 18/19] drm/i915/tc: Cache the pin assignment value
> 
> Cache the pin assignment value. This is more consistent with the way the max lane count value is tracked and a bit more efficient
> than reading out the same value from HW each time it's queried.
> 

Reviewed-by: Mika Kahola <mika.kahola at intel.com>

> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_tc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index d874217529951..f6bc253bec559 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -61,6 +61,7 @@ struct intel_tc_port {
>  	enum tc_port_mode mode;
>  	enum tc_port_mode init_mode;
>  	enum phy_fia phy_fia;
> +	enum intel_tc_pin_assignment pin_assignment;
>  	u8 phy_fia_idx;
>  	u8 max_lane_count;
>  };
> @@ -382,6 +383,7 @@ static int get_max_lane_count(struct intel_tc_port *tc)
> 
>  static void read_pin_configuration(struct intel_tc_port *tc)  {
> +	tc->pin_assignment = get_pin_assignment(tc);
>  	tc->max_lane_count = get_max_lane_count(tc);  }
> 
> @@ -403,7 +405,7 @@ intel_tc_port_get_pin_assignment(struct intel_digital_port *dig_port)
>  	if (!intel_encoder_is_tc(&dig_port->base))
>  		return INTEL_TC_PIN_ASSIGNMENT_NONE;
> 
> -	return get_pin_assignment(tc);
> +	return tc->pin_assignment;
>  }
> 
>  void intel_tc_port_set_fia_lane_count(struct intel_digital_port *dig_port,
> --
> 2.49.1



More information about the Intel-xe mailing list