✗ CI.checkpatch: warning for ANDROID: Add GPU work period support for Xe driver
Patchwork
patchwork at emeril.freedesktop.org
Fri Aug 8 10:30:49 UTC 2025
== Series Details ==
Series: ANDROID: Add GPU work period support for Xe driver
URL : https://patchwork.freedesktop.org/series/152678/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c298eac5978c38dcc62a70c0d73c91765e7cc296
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5fc47ee2e66d4822a31ec46c6ea4305f0f4f79dc
Author: Aakash Deep Sarkar <aakash.deep.sarkar at intel.com>
Date: Fri Aug 8 09:09:19 2025 +0000
ANDROID: Add GPU work period support for Xe driver
This patch implements the Android requirement GPU work
period event for Intel Xe driver.
|GpuWorkPeriodEvent| defines a non-overlapping, non-zero period
of time from |start_time_ns| (inclusive) until |end_time_ns|
(exclusive) for a given |uid|, and includes details of how much
work the GPU was performing for |uid| during the period. When
GPU work for a given |uid| runs on the GPU, the driver must track
one or more periods that cover the time where the work was running,
and emit events soon after.
Full requirement is defined in the following file:
https://cs.android.com/android/platform/superproject/main/+\
/main:frameworks/native/services/gpuservice/gpuwork/bpfprogs/gpuWork.c;l=35
The requirement is implemented using a timer to give periodic
interrupts and a worker thread per user id instance to accumulate
its run time on gpu and emit the event. Each user id instance is
tracked using a xe_user structure and the runtime is updated at
each timer interrupt. The timer period is hardcoded to 500 msecs.
The runtime on the gpu is collected for each xe file individually
inside the function xe_exec_queue_update_run_ticks() and accumulated
into the corresponding xe_user active_duration_ns field. The HW
Context timestamp field in the GTT is used to derive the runtime
in clock ticks and then converted into nanosecs before updating the
active duration.
Signed-off-by: Aakash Deep Sarkar <aakash.deep.sarkar at intel.com>
+ /mt/dim checkpatch 0a8f74a5dde6c5327dac9522cf1441003f2ebcba drm-intel
5fc47ee2e66d ANDROID: Add GPU work period support for Xe driver
-:72: CHECK:SPACING: No space is necessary after a cast
#72: FILE: drivers/gpu/drm/xe/xe_device.c:117:
+ uid = (int) cred->euid.val;
-:99: CHECK:LINE_SPACING: Please don't use multiple blank lines
#99: FILE: drivers/gpu/drm/xe/xe_device.c:144:
+
+
-:108: CHECK:SPACING: No space is necessary after a cast
#108: FILE: drivers/gpu/drm/xe/xe_device.c:153:
+ user->uid = (unsigned int) uid;
-:309: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#309: FILE: drivers/gpu/drm/xe/xe_drm_client.c:437:
+ list_for_each_entry(xef, &user->filelist, user_link) {
+
-:311: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#311: FILE: drivers/gpu/drm/xe/xe_drm_client.c:439:
+ wait_var_event(&xef->exec_queue.pending_removal,
+ !atomic_read(&xef->exec_queue.pending_removal));
-:540: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#540:
new file mode 100644
-:567: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#567: FILE: drivers/gpu/drm/xe/xe_power_gpu_work_period_trace.h:23:
+TRACE_EVENT(gpu_work_period,
+
-:568: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#568: FILE: drivers/gpu/drm/xe/xe_power_gpu_work_period_trace.h:24:
+ TP_PROTO(
-:578: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#578: FILE: drivers/gpu/drm/xe/xe_power_gpu_work_period_trace.h:34:
+ TP_STRUCT__entry(
-:586: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#586: FILE: drivers/gpu/drm/xe/xe_power_gpu_work_period_trace.h:42:
+ TP_fast_assign(
-:595: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#595: FILE: drivers/gpu/drm/xe/xe_power_gpu_work_period_trace.h:51:
+ TP_printk("gpu_id=%u uid=%u start_time_ns=%llu end_time_ns=%llu total_active_duration_ns=%llu",
+ __entry->gpu_id,
total: 0 errors, 1 warnings, 10 checks, 515 lines checked
More information about the Intel-xe
mailing list