[PATCH 1/2] drm/i915/dp: Refactor intel_dp_in_hdr_mode() for broader reuse

[Shankar, Uma]

> -----Original Message-----
> From: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>
> Sent: Wednesday, July 30, 2025 11:25 AM
> To: intel-xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> Cc: Deak, Imre <imre.deak at intel.com>; ville.syrjala at linux.intel.com; Shankar,
> Uma <uma.shankar at intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah at intel.com>
> Subject: [PATCH 1/2] drm/i915/dp: Refactor intel_dp_in_hdr_mode() for broader
> reuse
> 
> The intel_dp_in_hdr_mode() helper was previously defined in
> intel_dp_aux_backlight.c but is generally useful beyond that context. Move the
> function to intel_dp.c and declare it in intel_dp.h to make it accessible to other DP-
> related code paths that need to check HDR metadata state.
> 
> This is a pure refactor with no functional change and prepares for a follow-up
> patch that uses this helper.

Change Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c             | 13 +++++++++++++
>  drivers/gpu/drm/i915/display/intel_dp.h             |  1 +
>  .../gpu/drm/i915/display/intel_dp_aux_backlight.c   | 13 -------------
>  3 files changed, 14 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 54d88f24b689..59d814abd3a9 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2917,6 +2917,19 @@ static void intel_dp_compute_vsc_sdp(struct intel_dp
> *intel_dp,
>  	}
>  }
> 
> +bool
> +intel_dp_in_hdr_mode(const struct drm_connector_state *conn_state) {
> +	struct hdr_output_metadata *hdr_metadata;
> +
> +	if (!conn_state->hdr_output_metadata)
> +		return false;
> +
> +	hdr_metadata = conn_state->hdr_output_metadata->data;
> +
> +	return hdr_metadata->hdmi_metadata_type1.eotf ==
> +HDMI_EOTF_SMPTE_ST2084; }
> +
>  static void
>  intel_dp_compute_hdr_metadata_infoframe_sdp(struct intel_dp *intel_dp,
>  					    struct intel_crtc_state *crtc_state, diff -
> -git a/drivers/gpu/drm/i915/display/intel_dp.h
> b/drivers/gpu/drm/i915/display/intel_dp.h
> index 0657f5681196..5def589e3c0e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp.h
> @@ -214,5 +214,6 @@ int intel_dp_compute_min_hblank(struct intel_crtc_state
> *crtc_state,
> 
>  int intel_dp_dsc_bpp_step_x16(const struct intel_connector *connector);  void
> intel_dp_dpcd_set_probe(struct intel_dp *intel_dp, bool force_on_external);
> +bool intel_dp_in_hdr_mode(const struct drm_connector_state
> +*conn_state);
> 
>  #endif /* __INTEL_DP_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 41228478b21c..12084a542fc5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -225,19 +225,6 @@ intel_dp_aux_hdr_set_aux_backlight(const struct
> drm_connector_state *conn_state,
>  			connector->base.base.id, connector->base.name);  }
> 
> -static bool
> -intel_dp_in_hdr_mode(const struct drm_connector_state *conn_state) -{
> -	struct hdr_output_metadata *hdr_metadata;
> -
> -	if (!conn_state->hdr_output_metadata)
> -		return false;
> -
> -	hdr_metadata = conn_state->hdr_output_metadata->data;
> -
> -	return hdr_metadata->hdmi_metadata_type1.eotf ==
> HDMI_EOTF_SMPTE_ST2084;
> -}
> -
>  static void
>  intel_dp_aux_hdr_set_backlight(const struct drm_connector_state *conn_state,
> u32 level)  {
> --
> 2.25.1