✗ CI.checkpatch: warning for drm/xe: GPU frequency tracing support (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Aug 11 09:39:01 UTC 2025


== Series Details ==

Series: drm/xe: GPU frequency tracing support (rev2)
URL   : https://patchwork.freedesktop.org/series/152701/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c298eac5978c38dcc62a70c0d73c91765e7cc296
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 341695a17dc7de36ec25c159b210d819bb8ae296
Author: S Sebinraj <s.sebinraj at intel.com>
Date:   Mon Aug 11 14:04:14 2025 +0530

    drm/xe: GPU frequency tracing support
    
    A periodic GPU frequency monitoring and tracing program for the
    Xe driver. The implementation provides periodic sampling of
    GPU frequency through the Linux ftrace infrastructure.
    
    Key features:
    - Periodic GPU frequency sampling with configurable intervals
    - Immediate frequency change reporting via tracepoints
    - Integration with Linux ftrace subsystem under 'power' events
    - Per-GT (Graphics Technology) monitoring support
    - Dedicated workqueue for non-blocking frequency sampling
    - Configurable via CONFIG_DRM_XE_GPUFREQTRACER kernel option
    - The monitoring interval can be configured at runtime via the sysfs
      (default 5sec).
    
    The sysfs entry is at:
    /sys/module/xe/parameters/gpufreq_monitoring_interval_ms
    
    The tracepoint is exposed at:
    /sys/kernel/debug/tracing/events/power/gpu_frequency
    
    Format: {unsigned int state, unsigned int gpu_id}
    - state: GPU frequency in KHz
    - gpu_id: GPU clock domain identifier
    
    This enables userspace tools and system monitoring applications to track
    GPU frequency changes for power management analysis, performance tuning,
    and debugging purposes.
    
    Signed-off-by: S Sebinraj <s.sebinraj at intel.com>
+ /mt/dim checkpatch 27315c7bb830e06a1e63fe1fd656fda48365805c drm-intel
341695a17dc7 drm/xe: GPU frequency tracing support
-:131: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#131: 
new file mode 100644

-:192: CHECK:LINE_SPACING: Please don't use multiple blank lines
#192: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer.c:57:
+
+

-:273: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#273: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer.c:138:
+	drm_dbg(&gt_to_xe(gt)->drm, "monitoring started for GT%u with interval %u ms",
+		 gt->info.id, xe_modparam.gpufreq_monitoring_interval_ms);

-:323: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#323: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer.c:188:
+		xe_modparam.gpufreq_monitoring_interval_ms = XE_GPUFREQ_MONITORING_DEFAULT_INTERVAL_MS;

-:382: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#382: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer.c:247:
+	tracer_data->gt_data = drmm_kcalloc(&xe->drm, xe->info.gt_count,
+				       sizeof(*tracer_data->gt_data),

-:403: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#403: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer.c:268:
+		drm_dbg(&xe->drm, "GT%u initialized with global interval=%u ms",
+			 gt->info.id, xe_modparam.gpufreq_monitoring_interval_ms);

-:493: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#493: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer_trace.h:24:
+TRACE_EVENT(gpu_frequency,
+	TP_PROTO(unsigned int state, unsigned int gpu_id),

-:497: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#497: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer_trace.h:28:
+	TP_STRUCT__entry(

-:502: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#502: FILE: drivers/gpu/drm/xe/xe_gpufreqtracer_trace.h:33:
+	TP_fast_assign(

total: 0 errors, 2 warnings, 7 checks, 481 lines checked




More information about the Intel-xe mailing list