[PATCH v3 06/13] drm/xe/configfs: Simplify kernel doc
Riana Tauro
riana.tauro at intel.com
Wed Aug 13 06:23:33 UTC 2025
On 8/8/2025 10:59 PM, Lucas De Marchi wrote:
> From the caller perspective reading the documentation, there's no need
> to be so specific about everything the function is doing/checking. Just
> document the functionality a caller cares about.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro at intel.com>
> ---
> drivers/gpu/drm/xe/xe_configfs.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> index 853da2ee837ac..17b1d6ae1ff6a 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.c
> +++ b/drivers/gpu/drm/xe/xe_configfs.c
> @@ -389,10 +389,7 @@ static struct xe_config_group_device *find_xe_config_group_device(struct pci_dev
> * xe_configfs_get_survivability_mode - get configfs survivability mode attribute
> * @pdev: pci device
> *
> - * find the configfs group that belongs to the pci device and return
> - * the survivability mode attribute
> - *
> - * Return: survivability mode if config group is found, false otherwise
> + * Return: survivability_mode attribute in configfs
> */
> bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
> {
> @@ -409,11 +406,8 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
> }
>
> /**
> - * xe_configfs_clear_survivability_mode - clear configfs survivability mode attribute
> + * xe_configfs_clear_survivability_mode - clear configfs survivability mode
> * @pdev: pci device
> - *
> - * find the configfs group that belongs to the pci device and clear survivability
> - * mode attribute
> */
> void xe_configfs_clear_survivability_mode(struct pci_dev *pdev)
> {
> @@ -433,10 +427,7 @@ void xe_configfs_clear_survivability_mode(struct pci_dev *pdev)
> * xe_configfs_get_engines_allowed - get engine allowed mask from configfs
> * @pdev: pci device
> *
> - * Find the configfs group that belongs to the pci device and return
> - * the mask of engines allowed to be used.
> - *
> - * Return: engine mask with allowed engines
> + * Return: engine mask with allowed engines set in configfs
> */
> u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev)
> {
>
More information about the Intel-xe
mailing list