✗ CI.checkpatch: warning for drm/xe/guc: Add devm release action to safely tear down CT

Patchwork patchwork at emeril.freedesktop.org
Wed Aug 13 10:01:19 UTC 2025


== Series Details ==

Series: drm/xe/guc: Add devm release action to safely tear down CT
URL   : https://patchwork.freedesktop.org/series/152870/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6f9293a391ff3c575bc021f454be5d0a0c076f57
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit bec83213be029b21c3ad5829bedadfee4ab98925
Author: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
Date:   Wed Aug 13 15:42:25 2025 +0530

    drm/xe/guc: Add devm release action to safely tear down CT
    
    When a buffer object (BO) is allocated with the XE_BO_FLAG_GGTT_INVALIDATE
    flag, the driver initiates TLB invalidation requests via the CTB mechanism
    while releasing the BO. However a premature release of the CTB BO can lead
    to system crashes, as observed in:
    
    Oops: Oops: 0000 [#1] SMP NOPTI
    RIP: 0010:h2g_write+0x2f3/0x7c0 [xe]
    Call Trace:
     guc_ct_send_locked+0x8b/0x670 [xe]
     xe_guc_ct_send_locked+0x19/0x60 [xe]
     send_tlb_invalidation+0xb4/0x460 [xe]
     xe_gt_tlb_invalidation_ggtt+0x15e/0x2e0 [xe]
     ggtt_invalidate_gt_tlb.part.0+0x16/0x90 [xe]
     ggtt_node_remove+0x110/0x140 [xe]
     xe_ggtt_node_remove+0x40/0xa0 [xe]
     xe_ggtt_remove_bo+0x87/0x250 [xe]
    
    Introduce a devm-managed release action during xe_guc_ct_init() to ensure
    proper CTB disablement before resource deallocation, preventing the
    use-after-free scenario.
    
    Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: Matthew Auld <matthew.auld at intel.com>
    Cc: Summers Stuart <stuart.summers at intel.com>
+ /mt/dim checkpatch 546fc742f08b8dbd3fa1486933c9b15085e11d13 drm-intel
bec83213be02 drm/xe/guc: Add devm release action to safely tear down CT
-:104: WARNING:MISSING_FIXES_TAG: The commit message has 'Call Trace:', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 1 warnings, 0 checks, 55 lines checked




More information about the Intel-xe mailing list